[dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-04-28 Thread Dmitry Kozlyuk
Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Multi-process mode is not implemented and is forcefully disabled at startup. Signed-off-by: Dmitry Kozlyuk --- co

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-04-28 Thread Ranjit Menon
On 4/28/2020 4:50 PM, Dmitry Kozlyuk wrote: Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Multi-process mode is not implemented and is forcefully disabled at st

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-01 Thread Dmitry Kozlyuk
On 2020-04-28 18:18 GMT-0700 Ranjit Menon wrote: > On 4/28/2020 4:50 PM, Dmitry Kozlyuk wrote: [snip] > > +void * > > +eal_mem_reserve(void *requested_addr, size_t size, int flags) > > +{ > > + void *virt; > > + > > + /* Windows requires hugepages to be committed. */ > > + if (flags & EAL_RES

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-05 Thread Burakov, Anatoly
On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: Basic memory management supports core libraries and PMDs operating in IOVA as PA mode. It uses a kernel-mode driver, virt2phys, to obtain IOVAs of hugepages allocated from user-mode. Multi-process mode is not implemented and is forcefully disabled at s

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-05 Thread Dmitry Kozlyuk
On 2020-05-05 17:24 GMT+0100 Burakov, Anatoly wrote: > On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: > Lots of duplication... I wonder if it would be possible to share at > least some of this code in common. Tracking down bugs because of > duplicated code desync is always a pain... This was the m

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-06 Thread Burakov, Anatoly
On 06-May-20 12:20 AM, Dmitry Kozlyuk wrote: On 2020-05-05 17:24 GMT+0100 Burakov, Anatoly wrote: On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: Lots of duplication... I wonder if it would be possible to share at least some of this code in common. Tracking down bugs because of duplicated code desy

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-06 Thread Dmitry Kozlyuk
On 2020-05-06 10:46 GMT+0100 Burakov, Anatoly wrote: > On 06-May-20 12:20 AM, Dmitry Kozlyuk wrote: > > On 2020-05-05 17:24 GMT+0100 Burakov, Anatoly wrote: > >> On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: > >> Lots of duplication... I wonder if it would be possible to share at > >> least some o

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-07 Thread Burakov, Anatoly
On 06-May-20 10:53 PM, Dmitry Kozlyuk wrote: On 2020-05-06 10:46 GMT+0100 Burakov, Anatoly wrote: On 06-May-20 12:20 AM, Dmitry Kozlyuk wrote: On 2020-05-05 17:24 GMT+0100 Burakov, Anatoly wrote: On 29-Apr-20 12:50 AM, Dmitry Kozlyuk wrote: Lots of duplication... I wonder if it would be possib

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-13 Thread Fady Bader
Hi Dmitry, I'm using your latest memory management patchset and getting an error in the function VirualAlloc2 in eal_mem_commit, error code: 0x57 (ERROR_INVALID_PARAMETER). I'm using Windows server 2019 build 17763, and followed the steps to Grant *Lock pages in memory* Privilege. The parameters

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-13 Thread Dmitry Kozlyuk
On Wed, 13 May 2020 08:24:12 + Fady Bader wrote: > Hi Dmitry, > I'm using your latest memory management patchset and getting an error > in the function VirualAlloc2 in eal_mem_commit, error code: 0x57 > (ERROR_INVALID_PARAMETER). I'm using Windows server 2019 build 17763, > and followed the s

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-13 Thread Fady Bader
> -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, May 13, 2020 11:43 AM > To: Fady Bader > Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV) > ; Narcisa Ana Maria Vasile > ; Tal Shnaiderman ; > Thomas Monjalon ; Harini Ramakrishnan > ; Omar Cardona > ; Pallavi Kadam ; > Ranji

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-13 Thread Fady Bader
> -Original Message- > From: Fady Bader > Sent: Wednesday, May 13, 2020 12:09 PM > To: Dmitry Kozlyuk > Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV) > ; Narcisa Ana Maria Vasile > ; Tal Shnaiderman ; > Thomas Monjalon ; Harini Ramakrishnan > ; Omar Cardona > ; Pallavi Kadam ; > Ranjit

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-13 Thread Dmitry Kozlyuk
On Wed, 13 May 2020 09:09:22 + Fady Bader wrote: > > -Original Message- > > From: Dmitry Kozlyuk > > Sent: Wednesday, May 13, 2020 11:43 AM > > To: Fady Bader > > Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV) > > ; Narcisa Ana Maria Vasile > > ; Tal Shnaiderman > > ; Thomas Monjalo

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-13 Thread Fady Bader
> -Original Message- > From: Dmitry Kozlyuk > Sent: Wednesday, May 13, 2020 12:39 PM > To: Fady Bader > Cc: dev@dpdk.org; Dmitry Malloy (MESHCHANINOV) > ; Narcisa Ana Maria Vasile > ; Tal Shnaiderman ; > Thomas Monjalon ; Harini Ramakrishnan > ; Omar Cardona > ; Pallavi Kadam ; > Ranji

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-17 Thread Dmitry Kozlyuk
On Wed, 13 May 2020 12:25:10 + Fady Bader wrote: [snip] > > > > I meant the code of the application that calls > > rte_mempool_create(). Or is it one of the DPDK test applications? > > I got it from dpdk\app\test\test_mempool > > Line 496: > /* create a mempool (without cache) */ > mp_noc

Re: [dpdk-dev] [PATCH v4 8/8] eal/windows: implement basic memory management

2020-05-18 Thread Dmitry Kozlyuk
On Mon, 18 May 2020 03:17:04 +0300 Dmitry Kozlyuk wrote: > On Wed, 13 May 2020 12:25:10 + > Fady Bader wrote: > [snip] > > > > > > I meant the code of the application that calls > > > rte_mempool_create(). Or is it one of the DPDK test applications? > > > > > > > I got it from dpdk\app