Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-21 Thread oulijun
在 2020/10/21 17:38, Ferruh Yigit 写道: On 10/21/2020 9:19 AM, oulijun wrote: 在 2020/10/20 22:34, Ferruh Yigit 写道: On 10/20/2020 2:35 PM, oulijun wrote: 在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-21 Thread Ferruh Yigit
On 10/21/2020 9:19 AM, oulijun wrote: 在 2020/10/20 22:34, Ferruh Yigit 写道: On 10/20/2020 2:35 PM, oulijun wrote: 在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53,

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-21 Thread oulijun
在 2020/10/20 22:34, Ferruh Yigit 写道: On 10/20/2020 2:35 PM, oulijun wrote: 在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 2:35 PM, oulijun wrote: 在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigi

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread oulijun
在 2020/10/20 18:02, Ferruh Yigit 写道: On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wr

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread Ferruh Yigit
On 10/20/2020 10:00 AM, oulijun wrote: 在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd dri

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-20 Thread oulijun
在 2020/10/16 18:57, Ferruh Yigit 写道: On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration.

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-16 Thread Ophir Munk
Ferruh Yigit wrote: > Sent: Friday, October 16, 2020 1:57 PM > >> Lijun's idea can work. There was a problem in implementation related > >> to the key size assumption, which can be fixed. > >> > >> Even it is fixed, when user gives a rss rule without a key, we are > >> getting key from device an

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-16 Thread Ferruh Yigit
On 10/16/2020 11:04 AM, oulijun wrote: 在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key i

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-16 Thread oulijun
在 2020/10/16 14:46, Ophir Munk 写道: -Original Message- From: Ferruh Yigit <..> Ferruh, your suggestion ([1] + update) looks correct. I also verified it on mlx5 PMD. Advantage: it's a generic fix for all dpdk applications using rte_flows (not just testpmd). It reduces code.

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-16 Thread oulijun
在 2020/10/16 7:53, Ferruh Yigit 写道: On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Ophir Munk
> -Original Message- > From: Ferruh Yigit <..> > >> > > > > Ferruh, your suggestion ([1] + update) looks correct. I also verified it on > mlx5 PMD. > > Advantage: it's a generic fix for all dpdk applications using rte_flows (not > just testpmd). > > It reduces code. > > With this fix the

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Ajit Khaparde
On Thu, Oct 15, 2020 at 4:54 PM Ferruh Yigit wrote: > > On 10/16/2020 12:21 AM, Ophir Munk wrote: > >> From: Ferruh Yigit > > On 10/15/2020 1:41 PM, Lijun Ou wrote: > >> When start the testpmd, the pmd driver initializes the RSS > >> configuration. Generally, the recommended RSS hash

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Ferruh Yigit
On 10/16/2020 12:21 AM, Ophir Munk wrote: From: Ferruh Yigit On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver. In addition, the default key is differ

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Ophir Munk
> From: Ferruh Yigit > >>> On 10/15/2020 1:41 PM, Lijun Ou wrote: > When start the testpmd, the pmd driver initializes the RSS > configuration. Generally, the recommended RSS hash key is used as > the default key in the driver. In addition, the default key is > different from t

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Ferruh Yigit
On 10/15/2020 3:43 PM, Ferruh Yigit wrote: On 10/15/2020 3:04 PM, oulijun wrote: 在 2020/10/15 21:52, Ferruh Yigit 写道: On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the defaul

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Ferruh Yigit
On 10/15/2020 3:04 PM, oulijun wrote: 在 2020/10/15 21:52, Ferruh Yigit 写道: On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver. In addition, the defaul

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread oulijun
在 2020/10/15 21:52, Ferruh Yigit 写道: On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver. In addition, the default key is different from the default RS

Re: [dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Ferruh Yigit
On 10/15/2020 1:41 PM, Lijun Ou wrote: When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver. In addition, the default key is different from the default RSS flow in testpmd without specifying RSS

[dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Lijun Ou
When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver. In addition, the default key is different from the default RSS flow in testpmd without specifying RSS hash key. So. if you do not specify the R

[dpdk-dev] [PATCH v5] app/testpmd: fix the default RSS key configuration

2020-10-15 Thread Lijun Ou
When start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver. In addition, the default key is different from the default RSS flow in testpmd without specifying RSS hash key. So. if you do not specify the R