[dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-28 Thread Kevin Laatz
This patch adds CPU flags which will enable the detection of ISA features available on more recent x86 based CPUs. The CPUID leaf information can be found in Table 1-2. "Information Returned by CPUID Instruction" of this document: https://software.intel.com/sites/default/files/managed/c5/15/archit

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-28 Thread Ray Kinsella
On 28/04/2020 13:40, Kevin Laatz wrote: > This patch adds CPU flags which will enable the detection of ISA > features available on more recent x86 based CPUs. > > The CPUID leaf information can be found in > Table 1-2. "Information Returned by CPUID Instruction" of this document: > https://soft

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-28 Thread Laatz, Kevin
> > --- > > devtools/libabigail.abignore | 5 + > > lib/librte_eal/x86/include/rte_cpuflags.h | 19 +++ > > lib/librte_eal/x86/rte_cpuflags.c | 18 ++ > > 3 files changed, 42 insertions(+) > > > > diff --git a/devtools/libabigail.abignore

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-28 Thread Thomas Monjalon
28/04/2020 20:11, Laatz, Kevin: > > > --- a/devtools/libabigail.abignore > > > +++ b/devtools/libabigail.abignore > > > > Kevin - you still have the surpession. > > I am testing locally with 1.7.1, and it doesn't complain when I disable the > > supression. > > Are you seeing something different? >

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-28 Thread Stephen Hemminger
On Tue, 28 Apr 2020 17:39:24 +0100 Ray Kinsella wrote: > > + > > /* The last item */ > > RTE_CPUFLAG_NUMFLAGS, /**< This should always be the > > last! */ > > }; These kind of enums break API's. We should remove them all in 20.11.

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-29 Thread David Marchand
On Tue, Apr 28, 2020 at 6:39 PM Ray Kinsella wrote: > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > > index a59df8f13..045f436fb 100644 > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > Kevin - you still have the surpession. > I am tes

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-04-30 Thread Ray Kinsella
So that isn't the issue either. $ grep RTE_CPUFLAG_NUMFLAGS build-gcc-shared/install/dump/librte_eal.dump 4646: $ grep RTE_CPUFLAG_NUMFLAGS /build/dpdk/reference/v20.02/build-gcc-shared/dump/librte_eal.dump 3296: 1.7-1.fc31

Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags

2020-05-07 Thread Thomas Monjalon
> Acked-By: Ray Kinsella Applied, thanks