Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Gregory Etelson
Hello, ..snip.. > > The deprecation notice for `fragment_offset` > seems not implemented but removed. > > What do you think to remove the relevant part > that is implemented in this patch, > remove the residue in another patch explaining > why it is not implemented? I'll update the patch in v6.

Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Ferruh Yigit
On 10/12/2021 1:29 PM, Gregory Etelson wrote: RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplif

Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 13:29, Gregory Etelson wrote: > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `version' > and `ihl' IPv4 fields. Separated header fields definitions allow to > creat

[dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-12 Thread Gregory Etelson
RTE IPv4 header definition combines the `version' and `ihl' fields into a single structure member. This patch introduces dedicated structure members for both `version' and `ihl' IPv4 fields. Separated header fields definitions allow to create simplified code to match on the IHL value in a flow rul