[dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-29 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. Signed-off-by: Narcisa Vasile --- lib/librte_eal/windows/rte_thread.c | 65 ++--- 1 file changed, 50 insertions(+), 15 deletions(-) diff --git a/lib/librte_eal/windows/rte_th

Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-31 Thread Tal Shnaiderman
> Subject: [PATCH v5 03/10] windows/eal: translate Windows errors to errno- > style errors > > External email: Use caution opening links or attachments > > > From: Narcisa Vasile > > Add function to translate Windows error codes to errno-style error codes. > > Signed-off-by: Narcisa Vasile >

Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-03-31 Thread Nick Connolly
Also, I don't think this is a thread specific function, other implementations can use it in the future, maybe move it to rte_windows.h? I'd suggest that it's probably better suited to a .c file rather than a header.  As an example of what it might end up like see https://github.com/wpdk/wpdk

Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-04-01 Thread Tal Shnaiderman
> Subject: Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows > errors to errno-style errors > > External email: Use caution opening links or attachments > > > > Also, I don't think this is a thread specific function, other > > implementations >

Re: [dpdk-dev] [PATCH v5 03/10] windows/eal: translate Windows errors to errno-style errors

2021-04-01 Thread Narcisa Ana Maria Vasile
On Wed, Mar 31, 2021 at 01:56:09PM +, Tal Shnaiderman wrote: > > Subject: [PATCH v5 03/10] windows/eal: translate Windows errors to errno- > > style errors > > > > External email: Use caution opening links or attachments > > > > > > From: Narcisa Vasile > > > > Add function to translate Wi