Hi Reshma,
snipped
> > >
> > > > + fflush(stdout);
> > >
> > > Why is fflush used here and in below other places?
> > To ensure the stdout content is flushed out. We had used similar approach
> > to '
> > examples/l2fwd/main.c'
> >
>
> Can you elaborate more? What problem do you see if y
> -Original Message-
> From: Varghese, Vipin
> >
> > > + fflush(stdout);
> >
> > Why is fflush used here and in below other places?
> To ensure the stdout content is flushed out. We had used similar approach to '
> examples/l2fwd/main.c'
>
Can you elaborate more? What problem do you
On Tue, Apr 2, 2019 at 5:30 PM Varghese, Vipin
wrote:
> Hi David,
>
>
>
> snipped
> #define CMD_LINE_OPT_PDUMP "pdump"
> +#define CMD_LINE_OPT_PDUMP_NUM 1
> +#define CMD_LINE_OPT_MULTI "multi"
> +#define CMD_LINE_OPT_MULTI_NUM 2
> #define PDUMP_PORT_ARG "port"
> #define PDUMP_PCI_ARG "device_i
Hi Reshma,
snipped
> > +
> > + printf(" core (%u); port %u device (%s) queue %u\n",
> > + rte_lcore_id(), pt->port, pt->device_id, pt->queue);
>
> Log message can be improved to be " packet_dump for port running on
> core "
Thanks for the suggestion, but I am comfortable wit
> -Original Message-
> From: Varghese, Vipin
>
> @@ -152,7 +157,7 @@ pdump_usage(const char *prgname)
> "[ring-size=default:16384],"
> "[mbuf-size=default:2176],"
> "[total-num-mbufs= mbufs>default:65535]'\n",
> -
Hi David,
snipped
#define CMD_LINE_OPT_PDUMP "pdump"
+#define CMD_LINE_OPT_PDUMP_NUM 1
+#define CMD_LINE_OPT_MULTI "multi"
+#define CMD_LINE_OPT_MULTI_NUM 2
#define PDUMP_PORT_ARG "port"
#define PDUMP_PCI_ARG "device_id"
#define PDUMP_QUEUE_ARG "queue"
You'd better map to integers that do not
On Tue, Apr 2, 2019 at 11:18 AM Vipin Varghese
wrote:
> @@ -28,6 +28,9 @@
> #include
>
> #define CMD_LINE_OPT_PDUMP "pdump"
> +#define CMD_LINE_OPT_PDUMP_NUM 1
> +#define CMD_LINE_OPT_MULTI "multi"
> +#define CMD_LINE_OPT_MULTI_NUM 2
> #define PDUMP_PORT_ARG "port"
> #define PDUMP_PCI_ARG "d
Add option --multi, to enhance pdump application to allow capture
on unique cores for each --pdump option. If option --multi is ignored
the default capture occurs on single core for all --pdump options.
Signed-off-by: Vipin Varghese
---
app/pdump/main.c | 95 +++
8 matches
Mail list logo
