Re: [dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library()

2019-01-22 Thread Bruce Richardson
On Tue, Jan 22, 2019 at 02:09:41PM +, Luca Boccassi wrote: > On Tue, 2019-01-22 at 13:46 +, Bruce Richardson wrote: > > On Tue, Jan 22, 2019 at 01:10:52PM +, Luca Boccassi wrote: > > > Whenever possible (if the library ships a pkg-config file) use > > > meson's > > > dependency() functi

Re: [dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library()

2019-01-22 Thread Bruce Richardson
On Tue, Jan 22, 2019 at 01:10:52PM +, Luca Boccassi wrote: > Whenever possible (if the library ships a pkg-config file) use meson's > dependency() function to look for it, as it will automatically add it > to the Requires.private list if needed, to allow for static builds to > succeed for rever

Re: [dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library()

2019-01-22 Thread Luca Boccassi
On Tue, 2019-01-22 at 13:46 +, Bruce Richardson wrote: > On Tue, Jan 22, 2019 at 01:10:52PM +, Luca Boccassi wrote: > > Whenever possible (if the library ships a pkg-config file) use > > meson's > > dependency() function to look for it, as it will automatically add > > it > > to the Require

Re: [dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library()

2019-01-22 Thread Bruce Richardson
On Tue, Jan 22, 2019 at 01:10:52PM +, Luca Boccassi wrote: > Whenever possible (if the library ships a pkg-config file) use meson's > dependency() function to look for it, as it will automatically add it > to the Requires.private list if needed, to allow for static builds to > succeed for rever

[dpdk-dev] [PATCH v5 2/4] build: use dependency() instead of find_library()

2019-01-22 Thread Luca Boccassi
Whenever possible (if the library ships a pkg-config file) use meson's dependency() function to look for it, as it will automatically add it to the Requires.private list if needed, to allow for static builds to succeed for reverse dependencies of DPDK. Otherwise the recursive dependencies are not p