Re: [dpdk-dev] [PATCH v5 2/5] app/flow-perf: add insertion rate calculation

2020-05-07 Thread Wisam Monther
t;david.march...@redhat.com >Subject: Re: [dpdk-dev] [PATCH v5 2/5] app/flow-perf: add insertion rate >calculation > >My biggest concert with the patch is usage of huge number of global variables >which makes the code hard to read, understand and maintain. See my notes >below

Re: [dpdk-dev] [PATCH v5 2/5] app/flow-perf: add insertion rate calculation

2020-05-06 Thread Andrew Rybchenko
My biggest concert with the patch is usage of huge number of global variables which makes the code hard to read, understand and maintain. See my notes below. Please, share your thoughts. On 5/6/20 3:36 PM, Wisam Jaddo wrote: > Add insertion rate calculation feature into flow > performance applicat

[dpdk-dev] [PATCH v5 2/5] app/flow-perf: add insertion rate calculation

2020-05-06 Thread Wisam Jaddo
Add insertion rate calculation feature into flow performance application. The application now provide the ability to test insertion rate of specific rte_flow rule, by stressing it to the NIC, and calculate the insertion rate. The application offers some options in the command line, to configure w