Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-28 Thread 谢华伟(此时此刻)
On 2021/1/28 0:45, Ferruh Yigit wrote: On 1/27/2021 2:43 PM, 谢华伟(此时此刻) wrote: On 2021/1/27 18:32, Ferruh Yigit wrote: I was waiting for clarification if this can be solved in virtio, which seems clarified and decided to go with this patch, I am OK to proceed with patch 1 & 2. But first pa

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-27 Thread Ferruh Yigit
On 1/27/2021 2:43 PM, 谢华伟(此时此刻) wrote: On 2021/1/27 18:32, Ferruh Yigit wrote: I was waiting for clarification if this can be solved in virtio, which seems clarified and decided to go with this patch, I am OK to proceed with patch 1 & 2. But first patch changes how PIO address get, it changes

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-27 Thread 谢华伟(此时此刻)
On 2021/1/27 18:32, Ferruh Yigit wrote: I was waiting for clarification if this can be solved in virtio, which seems clarified and decided to go with this patch, I am OK to proceed with patch 1 & 2. But first patch changes how PIO address get, it changes the Linux interface used to get the

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-27 Thread Maxime Coquelin
On 1/27/21 11:32 AM, Ferruh Yigit wrote: > On 1/26/2021 10:44 AM, Maxime Coquelin wrote: >> >> >> On 1/22/21 8:25 AM, 谢华伟(此时此刻) wrote: >>> >>> On 2021/1/21 23:38, Maxime Coquelin wrote: > Do you mean we apply or abandon patch 3? I am both OK. The first > priority to me is to enable MMIO

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-27 Thread Ferruh Yigit
On 1/26/2021 10:44 AM, Maxime Coquelin wrote: On 1/22/21 8:25 AM, 谢华伟(此时此刻) wrote: On 2021/1/21 23:38, Maxime Coquelin wrote: Do you mean we apply or abandon patch 3? I am both OK. The first priority to me is to enable MMIO bar support. OK, so yes, I think we should abandon patch 2 and patc

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-26 Thread 谢华伟(此时此刻)
On 2021/1/26 20:35, Maxime Coquelin wrote: On 1/26/21 1:30 PM, 谢华伟(此时此刻) wrote: On 2021/1/22 15:25, chris wrote: On 2021/1/21 23:38, Maxime Coquelin wrote: Do you mean we apply or abandon patch 3? I am both OK. The first priority to me is to enable MMIO bar support. OK, so yes, I think we

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-26 Thread Maxime Coquelin
On 1/26/21 1:30 PM, 谢华伟(此时此刻) wrote: > > On 2021/1/22 15:25, chris wrote: >> >> On 2021/1/21 23:38, Maxime Coquelin wrote: Do you mean we apply or abandon patch 3? I am both OK. The first priority to me is to enable MMIO bar support. >>> OK, so yes, I think we should abandon patch 2 a

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-26 Thread 谢华伟(此时此刻)
On 2021/1/22 15:25, chris wrote: On 2021/1/21 23:38, Maxime Coquelin wrote: Do you mean we apply or abandon patch 3? I am both OK. The first priority to me is to enable MMIO bar support. OK, so yes, I think we should abandon patch 2 and patch 3. For patch 1, it looks valid to me, but I'll le

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-26 Thread Maxime Coquelin
On 1/22/21 8:25 AM, 谢华伟(此时此刻) wrote: > > On 2021/1/21 23:38, Maxime Coquelin wrote: >>> Do you mean we apply or abandon patch 3? I am both OK. The first >>> priority to me is to enable MMIO bar support. >> OK, so yes, I think we should abandon patch 2 and patch 3. >> For patch 1, it looks valid

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread 谢华伟(此时此刻)
On 2021/1/21 23:38, Maxime Coquelin wrote: Do you mean we apply or abandon patch 3? I am both OK. The first priority to me is to enable MMIO bar support. OK, so yes, I think we should abandon patch 2 and patch 3. For patch 1, it looks valid to me, but I'll let Ferruh decide. For your device,

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread Maxime Coquelin
On 1/21/21 3:57 PM, 谢华伟(此时此刻) wrote: > > On 2021/1/21 16:29, Maxime Coquelin wrote: >> >> On 1/20/21 3:54 PM, 谢华伟(此时此刻) wrote: >>> On 2021/1/13 0:58, Maxime Coquelin wrote: On 1/12/21 10:37 AM, Maxime Coquelin wrote: > bus/pci: ... > > On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote:

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread 谢华伟(此时此刻)
" I think that using inb/outb in the case of VFIO with IOMMU enabled won't work without cap_sys_rawio, and using it in the case of VFIO with IOMMU disabled just bypasses VFIO and so is not correct. Get your concern. PIO bar:     HW virtio on HW machine: any vendor implements hardware virti

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread 谢华伟(此时此刻)
On 2021/1/21 16:29, Maxime Coquelin wrote: On 1/20/21 3:54 PM, 谢华伟(此时此刻) wrote: On 2021/1/13 0:58, Maxime Coquelin wrote: On 1/12/21 10:37 AM, Maxime Coquelin wrote: bus/pci: ... On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" VFIO should use the same way to map/read/write PORT

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-21 Thread Maxime Coquelin
On 1/20/21 3:54 PM, 谢华伟(此时此刻) wrote: > > On 2021/1/13 0:58, Maxime Coquelin wrote: >> >> On 1/12/21 10:37 AM, Maxime Coquelin wrote: >>> bus/pci: ... >>> >>> On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" VFIO should use the same way to map/read/write PORT IO as UIO, f

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-20 Thread 谢华伟(此时此刻)
On 2021/1/13 0:58, Maxime Coquelin wrote: On 1/12/21 10:37 AM, Maxime Coquelin wrote: bus/pci: ... On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: From: "huawei.xhw" VFIO should use the same way to map/read/write PORT IO as UIO, for virtio PMD. Please provide more details in the commit message on

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-12 Thread Maxime Coquelin
On 1/12/21 10:37 AM, Maxime Coquelin wrote: > bus/pci: ... > > On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: >> From: "huawei.xhw" >> >> VFIO should use the same way to map/read/write PORT IO as UIO, for >> virtio PMD. > > Please provide more details in the commit message on why the way VFIO > works

Re: [dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2021-01-12 Thread Maxime Coquelin
bus/pci: ... On 10/22/20 5:51 PM, 谢华伟(此时此刻) wrote: > From: "huawei.xhw" > > VFIO should use the same way to map/read/write PORT IO as UIO, for > virtio PMD. Please provide more details in the commit message on why the way VFIO works today is wrong (The cover letter is lost once applied). > Sig

[dpdk-dev] [PATCH v5 3/3] PCI: don't use vfio ioctl call to access PIO resource

2020-10-22 Thread 谢华伟(此时此刻)
From: "huawei.xhw" VFIO should use the same way to map/read/write PORT IO as UIO, for virtio PMD. Signed-off-by: huawei.xhw --- drivers/bus/pci/linux/pci.c | 8 drivers/bus/pci/linux/pci_uio.c | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/bus/pci