[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

Xie, I think it is OK to merge first three patches at the moment. I'm going to implement a new scheme in a different ioctl soon. Pavel

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

On 7/11/2015 11:08 PM, Pavel Boldin wrote: > Xie, All, > > Please find my comments intermixed below. > > On Fri, Jul 10, 2015 at 6:42 PM, Xie, Huawei > wrote: > > Don't know why previous mail get messed. > > On 7/10/2015 10:50 PM, Pavel Boldin wrote: > X

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

Xie, All, Please find my comments intermixed below. On Fri, Jul 10, 2015 at 6:42 PM, Xie, Huawei wrote: > Don't know why previous mail get messed. > > On 7/10/2015 10:50 PM, Pavel Boldin wrote: > Xie, > > Regarding the patches: > 1. The replaced code in fourth patch is checked to be a copy-past

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

Xie, Regarding the patches: 1. The replaced code in fourth patch is checked to be a copy-paste of the `sys_close` syscall. 2. It is not uncommon for the applications to close FD making it allocated for a different file. In our particular case the file is closed in the *source* process and *added*

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

2015-07-10 15:42, Xie, Huawei: > Don't know why previous mail get messed. Same problem with this one. It's maybe because you send HTML mail which is wrongly translated in plain text. > On 7/10/2015 10:50 PM, Pavel Boldin wrote: > Xie, > > Regarding the patches: > 1. The replaced code in fourth p

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

On 7/10/2015 11:50 PM, Thomas Monjalon wrote: > 2015-07-10 15:42, Xie, Huawei: >> Don't know why previous mail get messed. > Same problem with this one. > It's maybe because you send HTML mail which is wrongly translated in plain > text. Have something to to with Pavel? :). I remember the format u

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

Don't know why previous mail get messed. On 7/10/2015 10:50 PM, Pavel Boldin wrote: Xie, Regarding the patches: 1. The replaced code in fourth patch is checked to be a copy-paste of the `sys_close` syscall. sys_close does extra cleanup than the replaced coe. My concern is, for example, sys_clo

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

On 7/10/2015 10:50 PM, Pavel Boldin wrote: Xie, Regarding the patches: 1. The replaced code in fourth patch is checked to be a copy-paste of the `sys_close` syscall. sys_close does extra cleanup than the replaced code. My concern is, for example, sys_close will mark the fd as next-to-be-allocate

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

On 6/17/2015 11:24 PM, Thomas Monjalon wrote: > 2015-05-07 06:54, Xie, Huawei: >> On 4/16/2015 7:48 PM, Pavel Boldin wrote: >>> + /* Closing the source_fd */ >>> + ret = sys_close(eventfd_copy.source_fd); >> Pavel: >> Here we close the fd and re-install a new file on this fd later. >> sys_clos

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

Ping 2015-06-17 17:24, Thomas Monjalon: > 2015-05-07 06:54, Xie, Huawei: > > On 4/16/2015 7:48 PM, Pavel Boldin wrote: > > > + /* Closing the source_fd */ > > > + ret = sys_close(eventfd_copy.source_fd); > > Pavel: > > Here we close the fd and re-install a new file on this fd later. > > sys_close

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

2015-05-07 06:54, Xie, Huawei: > On 4/16/2015 7:48 PM, Pavel Boldin wrote: > > + /* Closing the source_fd */ > > + ret = sys_close(eventfd_copy.source_fd); > Pavel: > Here we close the fd and re-install a new file on this fd later. > sys_close does all cleanup. > But, for instance, if we alloc

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

On 4/16/2015 7:48 PM, Pavel Boldin wrote: > Replace copy-pasted `fget_from_files' -> `filp_close' with > a `sys_close' call. > > Signed-off-by: Pavel Boldin > --- > lib/librte_vhost/eventfd_link/eventfd_link.c | 49 > +++- > 1 file changed, 12 insertions(+), 37 deletions(

[dpdk-dev] [PATCH v5 4/5] vhost: eventfd_link: replace copy-pasted sys_close

Replace copy-pasted `fget_from_files' -> `filp_close' with a `sys_close' call. Signed-off-by: Pavel Boldin --- lib/librte_vhost/eventfd_link/eventfd_link.c | 49 +++- 1 file changed, 12 insertions(+), 37 deletions(-) diff --git a/lib/librte_vhost/eventfd_link/eventfd_lin