Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-11 Thread lihuisong (C)
在 2021/10/12 4:15, Ferruh Yigit 写道: On 10/9/2021 12:43 PM, lihuisong (C) wrote: Hi, Ferruh 在 2021/10/8 0:56, Ferruh Yigit 写道: Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-11 Thread Ferruh Yigit
On 10/9/2021 12:43 PM, lihuisong (C) wrote: Hi, Ferruh 在 2021/10/8 0:56, Ferruh Yigit 写道: Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into commo

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-11 Thread Ferruh Yigit
On 10/8/2021 5:51 PM, Ananyev, Konstantin wrote: Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also thi

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-09 Thread lihuisong (C)
Hi, Ferruh 在 2021/10/8 0:56, Ferruh Yigit 写道: Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also this has

Re: [dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-08 Thread Ananyev, Konstantin
> Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but > have slightly different checks. Like one checks min MTU against > RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. > > Checks moved into common function to unify the checks. Also this has > benefit to have common error logs.

[dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-07 Thread Ferruh Yigit
Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also this has benefit to have common error logs. Suggested-by