Re: [dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-07 Thread Olivier MATZ
On Thu, Sep 07, 2017 at 01:45:58PM +0530, santosh wrote: > > The API is correct, but the flags should simply be returned, not or-ed. > > I think it should be kept as simple as possible: a function called > > get_somthing() is expected to return it without doing anything else. > > Sorry if I wasn't

Re: [dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-07 Thread santosh
On Thursday 07 September 2017 01:29 PM, Olivier MATZ wrote: > On Wed, Sep 06, 2017 at 04:58:31PM +0530, Santosh Shukla wrote: >> Allow mempool driver to advertise his pool capability. >> For that pupose, an api(rte_mempool_ops_get_capabilities) > typo: pupose -> purpose v6. >> ... >> --- a/lib/l

Re: [dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-07 Thread Olivier MATZ
On Wed, Sep 06, 2017 at 04:58:31PM +0530, Santosh Shukla wrote: > Allow mempool driver to advertise his pool capability. > For that pupose, an api(rte_mempool_ops_get_capabilities) typo: pupose -> purpose > ... > --- a/lib/librte_mempool/rte_mempool.c > +++ b/lib/librte_mempool/rte_mempool.c > @@

[dpdk-dev] [PATCH v5 5/8] mempool: get the mempool capability

2017-09-06 Thread Santosh Shukla
Allow mempool driver to advertise his pool capability. For that pupose, an api(rte_mempool_ops_get_capabilities) and ->get_capability() handler has been introduced. - Upon ->get_capabilities() call, mempool driver will advertise his capability by oring to mempool 'flags'. Signed-off-by: Santosh Sh