OK sure will do that.
-Original Message-
From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
Sent: Tuesday, September 27, 2016 7:12 PM
To: Dey, Souvik
Cc: Stephen Hemminger ; Kavanagh, Mark B
; dev at dpdk.org
Subject: Re: [PATCH v6] net/virtio: add set_mtu in virtio
On Tue, Sep 27
On Tue, Sep 27, 2016 at 08:44:20PM +, Dey, Souvik wrote:
> Hi Stephen,
> So what should be my next steps , should I submit a v7 for this patch
> or you suggest otherwise.
Yes, please. Another note is please don't use white space for
indentation, use TAB instead.
-yliu
>
> --
Hi Stephen,
So what should be my next steps , should I submit a v7 for this patch
or you suggest otherwise.
--
Regards,
Souvik
-Original Message-
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Tuesday, September 27, 2016 2:57 PM
To: Dey, Souvik
Cc: Kavanagh,
Hi All,
Any further updates/comments on this ?
--
Regards,
Souvik
-Original Message-
From: Yuanhan Liu [mailto:yuanhan@linux.intel.com]
Sent: Sunday, September 25, 2016 11:21 PM
To: Stephen Hemminger
Cc: Dey, Souvik ; Kavanagh, Mark B ; dev at dpdk.org
Subject: Re: [PATCH v6
On Fri, 23 Sep 2016 15:17:37 +
"Dey, Souvik" wrote:
> Hi Liu/Mark/Stephen,
>
> I have tried to modify the code with all of your latest
> comments. Do let me know if this looks fine or you have more comments.
>
>
>
> Changes done :
>
> -- max frame ize is compare to VIRTIO_
Hi Stephen,
Are you okay with this change?
--yliu
On Fri, Sep 23, 2016 at 03:17:37PM +, Dey, Souvik wrote:
> Hi Liu/Mark/Stephen,
>
> I have tried to modify the code with all of your latest
> comments.
> Do let me know if this looks fine or you have more comments.
>
On Wed, Sep 21, 2016 at 06:45:05PM -0700, Stephen Hemminger wrote:
> On Thu, 22 Sep 2016 00:08:38 +
> "Dey, Souvik" wrote:
>
> > Answers inline.
> >
> > --
> > Regards,
> > Souvik
> >
> > -Original Message-
> > From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> > Sent
Hi Liu/Mark/Stephen,
I have tried to modify the code with all of your latest comments.
Do let me know if this looks fine or you have more comments.
Changes done :
-- max frame ize is compare to VIRTIO_MAX_RX_PKTLEN instead of
dev_info.max_rx_pktlen
-- removed the CRC_LEN from
>Subject: Re: [PATCH v6] net/virtio: add set_mtu in virtio
>
>On Wed, Sep 21, 2016 at 06:45:05PM -0700, Stephen Hemminger wrote:
>> On Thu, 22 Sep 2016 00:08:38 +
>> "Dey, Souvik" wrote:
>>
>> > Answers inline.
>> >
>> > --
>> > Regards,
>> > Souvik
>> >
>> > -Original Message-
>> > Fr
Virtio interfaces do not currently allow the user to specify a particular
Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces
is typically set to the Ethernet default value of 1500.
This is problematic in the case of cloud deployments, in which a specific
(and potentially
On Thu, 22 Sep 2016 00:08:38 +
"Dey, Souvik" wrote:
> I am fine with the general idea of this patch but:
> 1. Calling virtio_dev_info_get is needlessly wasteful when all you want
> is to access the max packet length. Since max_rx_pktlen is always
> VIRTIO_MAX_RX_PKTLEN, please jus
I still fail to understand how the dev_info.max_rx_pktlen is wrong here, and
the hw->rx_max_pktlen is defined at all ? If you see the other driver code we
have used the same way there too. Also for the vlan part isn't it better the
take the worst case for the mtu lower boundary check, as that wi
Answers inline.
--
Regards,
Souvik
-Original Message-
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Wednesday, September 21, 2016 7:22 PM
To: Dey, Souvik
Cc: mark.b.kavanagh at intel.com; yuanhan.liu at linux.intel.com; dev at
dpdk.org
Subject: Re: [PATCH v6] net/vi
From: souvikdey33
Virtio interfaces do not currently allow the user to specify a particular
Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces
is typically set to the Ethernet default value of 1500.
This is problematic in the case of cloud deployments, in which a specif
On Thu, 22 Sep 2016 00:08:38 +
"Dey, Souvik" wrote:
> Answers inline.
>
> --
> Regards,
> Souvik
>
> -Original Message-
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Wednesday, September 21, 2016 7:22 PM
> To: Dey, Souvik
> Cc: mark.b.kavanagh at intel.c
From: souvikdey33
Virtio interfaces do not currently allow the user to specify a particular
Maximum Transmission Unit (MTU).Consequently, the MTU of Virtio interfaces
is typically set to the Ethernet default value of 1500.
This is problematic in the case of cloud deployments, in which a specif
On Wed, 21 Sep 2016 19:11:47 -0400
Dey wrote:
>
> +
> +#define VLAN_TAG_SIZE 4/* 802.3ac tag (not DMA'd) */
> +
> +static int virtio_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
> +{
> + struct rte_eth_dev_info dev_info;
> + uint32_t ether_hdr_len = ETHER_HDR_LEN + E
17 matches
Mail list logo
