[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-29 Thread Thomas Monjalon
2016-02-29 12:51, Panu Matilainen: > On 02/24/2016 03:23 PM, Ananyev, Konstantin wrote: > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > >> On 02/23/2016 07:35 AM, Xie, Huawei wrote: > >>> On 2/22/2016 10:52 PM, Xie, Huawei wrote: > On 2/4/2016 1:24 AM, Olivier MAT

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-29 Thread Panu Matilainen
rg >> Cc: dprovan at bivio.net >> Subject: Re: [dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk >> API >> >> On 02/23/2016 07:35 AM, Xie, Huawei wrote: >>> On 2/22/2016 10:52 PM, Xie, Huawei wrote: >>>> On 2/4/2016 1:24 AM, Olivie

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-26 Thread Olivier MATZ
Hi Huawei, On 02/26/2016 10:07 AM, Xie, Huawei wrote: > On 2/26/2016 4:56 PM, Olivier MATZ wrote: >> test_one_pktmbuf(struct rte_mbuf *m) >> { >> /* same as before without the allocation/free */ >> } >> >> test_pkt_mbuf(void) >> { >> m = rte_pktmbuf_alloc(pool); >> test_one_pktmbuf(

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-26 Thread Olivier MATZ
On 02/23/2016 06:35 AM, Xie, Huawei wrote: >>> Also, it would be nice to have a simple test function in >>> app/test/test_mbuf.c. For instance, you could update >>> test_one_pktmbuf() to take a mbuf pointer as a parameter and remove >>> the mbuf allocation from the function. Then it could be call

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-26 Thread Olivier MATZ
On 02/26/2016 08:39 AM, Xie, Huawei wrote: With 8 mbufs allocated, there is about 6% performance increase using inline. With 16 mbufs allocated, we could still observe obvious performance difference, though only 1%-2% > > On 2/24/2016 9:23 PM, Ananyev, Konstantin wrote: >>

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-26 Thread Xie, Huawei
On 2/26/2016 4:56 PM, Olivier MATZ wrote: > > On 02/23/2016 06:35 AM, Xie, Huawei wrote: Also, it would be nice to have a simple test function in app/test/test_mbuf.c. For instance, you could update test_one_pktmbuf() to take a mbuf pointer as a parameter and remove the mbuf all

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-26 Thread Xie, Huawei
rg >> Cc: dprovan at bivio.net >> Subject: Re: [dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk >> API >> >> On 02/23/2016 07:35 AM, Xie, Huawei wrote: >>> On 2/22/2016 10:52 PM, Xie, Huawei wrote: >>>> On 2/4/2016 1:24 AM, Olivie

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-24 Thread Panu Matilainen
On 02/23/2016 07:35 AM, Xie, Huawei wrote: > On 2/22/2016 10:52 PM, Xie, Huawei wrote: >> On 2/4/2016 1:24 AM, Olivier MATZ wrote: >>> Hi, >>> >>> On 01/27/2016 02:56 PM, Panu Matilainen wrote: Since rte_pktmbuf_alloc_bulk() is an inline function, it is not part of the library ABI and sho

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-24 Thread Ananyev, Konstantin
Hi Panu, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Wednesday, February 24, 2016 12:12 PM > To: Xie, Huawei; Olivier MATZ; dev at dpdk.org > Cc: dprovan at bivio.net > Subject: Re: [dpdk-dev] [PATCH v6

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-23 Thread Xie, Huawei
On 2/22/2016 10:52 PM, Xie, Huawei wrote: > On 2/4/2016 1:24 AM, Olivier MATZ wrote: >> Hi, >> >> On 01/27/2016 02:56 PM, Panu Matilainen wrote: >>> Since rte_pktmbuf_alloc_bulk() is an inline function, it is not part of >>> the library ABI and should not be listed in the version map. >>> >>> I ass

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-22 Thread Xie, Huawei
On 2/4/2016 1:24 AM, Olivier MATZ wrote: > Hi, > > On 01/27/2016 02:56 PM, Panu Matilainen wrote: >> >> Since rte_pktmbuf_alloc_bulk() is an inline function, it is not part of >> the library ABI and should not be listed in the version map. >> >> I assume its inline for performance reasons, but then

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-02-03 Thread Olivier MATZ
Hi, On 01/27/2016 02:56 PM, Panu Matilainen wrote: > > Since rte_pktmbuf_alloc_bulk() is an inline function, it is not part of > the library ABI and should not be listed in the version map. > > I assume its inline for performance reasons, but then you lose the > benefits of dynamic linking such as

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-01-27 Thread Panu Matilainen
On 01/26/2016 07:03 PM, Huawei Xie wrote: > v6 changes: > reflect the changes in release notes and library version map file > revise our duff's code style a bit to make it more readable > > v5 changes: > add comment about duff's device and our variant implementation > > v3 changes: > move w

[dpdk-dev] [PATCH v6 1/2] mbuf: provide rte_pktmbuf_alloc_bulk API

2016-01-27 Thread Huawei Xie
v6 changes: reflect the changes in release notes and library version map file revise our duff's code style a bit to make it more readable v5 changes: add comment about duff's device and our variant implementation v3 changes: move while after case 0 add context about duff's device and why we