Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-16 Thread Remy Horton
On 12/01/2017 19:05, Thomas Monjalon wrote: 2017-01-12 15:30, Remy Horton: [..] The metric library hold two sets of values: Ones specific to ports, and ones that are global/aggregate. Agree "non port" is not the clearest choice of name.. I think you should not use the word "port" at all. Ch

Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-12 Thread Thomas Monjalon
2017-01-12 15:30, Remy Horton: > > On 12/01/2017 13:22, Thomas Monjalon wrote: > > 2017-01-12 00:03, Remy Horton: > [..] > >> --- /dev/null > >> +++ b/lib/librte_metrics/rte_metrics.h > >> +/** Used to indicate port-independent information */ > >> +#define RTE_METRICS_NONPORT -1 > > > > I do not u

Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-12 Thread Remy Horton
On 12/01/2017 13:22, Thomas Monjalon wrote: 2017-01-12 00:03, Remy Horton: [..] --- /dev/null +++ b/lib/librte_metrics/rte_metrics.h +/** Used to indicate port-independent information */ +#define RTE_METRICS_NONPORT -1 I do not understand this constant. Why using the word "port" to name any

Re: [dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-12 Thread Thomas Monjalon
2017-01-12 00:03, Remy Horton: > This patch adds a new information metric library that allows other > modules to register named metrics and update their values. It is > intended to be independent of ethdev, rather than mixing ethdev > and non-ethdev information in xstats. [...] > --- a/doc/api/dox

[dpdk-dev] [PATCH v6 1/4] lib: add information metrics library

2017-01-11 Thread Remy Horton
This patch adds a new information metric library that allows other modules to register named metrics and update their values. It is intended to be independent of ethdev, rather than mixing ethdev and non-ethdev information in xstats. Signed-off-by: Remy Horton --- MAINTAINERS