Re: [dpdk-dev] [PATCH v6 2/6] raw/ntb: add intel ntb support

2019-06-18 Thread Wu, Jingjing
One general comment: Think about to use rte_read32() and rte_write32() when reading and writing registers. Or you can define a Macro or inline function for NTB driver to touch registers. Then you can omit lots of "(char *)hw->pci_dev->mem_resource[0].addr " and "*((volatile uint32_t *)" like th

[dpdk-dev] [PATCH v6 2/6] raw/ntb: add intel ntb support

2019-06-17 Thread Xiaoyun Li
Add in the list of registers for the device. And enable ntb device ops for intel skylake platform. Signed-off-by: Xiaoyun Li --- drivers/raw/ntb_rawdev/Makefile | 1 + drivers/raw/ntb_rawdev/meson.build| 3 +- drivers/raw/ntb_rawdev/ntb_hw_intel.c | 368 ++