Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-17 Thread Shreyansh Jain
On Tuesday 17 January 2017 03:28 PM, Ferruh Yigit wrote: On 1/17/2017 4:54 AM, Shreyansh Jain wrote: Hello Ferruh, On Tuesday 17 January 2017 01:23 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Matching of PCI device address and driver ID table is being done at two discr

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-17 Thread Shreyansh Jain
On Monday 16 January 2017 11:54 PM, Stephen Hemminger wrote: On Mon, 16 Jan 2017 21:08:22 +0530 Shreyansh Jain wrote: -rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct rte_pci_device *dev) +int +rte_pci_match(struct rte_pci_driver *pci_drv, + struct rte_pci_devic

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-17 Thread Ferruh Yigit
On 1/17/2017 4:54 AM, Shreyansh Jain wrote: > Hello Ferruh, > > On Tuesday 17 January 2017 01:23 AM, Ferruh Yigit wrote: >> On 1/16/2017 3:38 PM, Shreyansh Jain wrote: >>> Matching of PCI device address and driver ID table is being done at two >>> discreet locations duplicating the code. (rte_eal_

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Shreyansh Jain
Hello Ferruh, On Tuesday 17 January 2017 01:23 AM, Ferruh Yigit wrote: On 1/16/2017 3:38 PM, Shreyansh Jain wrote: Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitti

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Ferruh Yigit
On 1/16/2017 3:38 PM, Shreyansh Jain wrote: > Matching of PCI device address and driver ID table is being done at two > discreet locations duplicating the code. (rte_eal_pci_probe_one_driver > and rte_eal_pci_detach_dev). > > Splitting the matching function into a public fn rte_pci_match. > > Sig

Re: [dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Stephen Hemminger
On Mon, 16 Jan 2017 21:08:22 +0530 Shreyansh Jain wrote: > -rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, struct > rte_pci_device *dev) > +int > +rte_pci_match(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev) Use const?

[dpdk-dev] [PATCH v6 3/8] pci: split match and probe function

2017-01-16 Thread Shreyansh Jain
Matching of PCI device address and driver ID table is being done at two discreet locations duplicating the code. (rte_eal_pci_probe_one_driver and rte_eal_pci_detach_dev). Splitting the matching function into a public fn rte_pci_match. Signed-off-by: Shreyansh Jain --- lib/librte_eal/bsdapp/eal