Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Thomas Monjalon
20/04/2021 16:20, Kevin Traynor: > On 20/04/2021 11:04, Thomas Monjalon wrote: > > 17/04/2021 09:39, Min Hu (Connor): > >> + if (eth_link == NULL) { > >> + RTE_ETHDEV_LOG(ERR, > >> + "Cannot get nowait ethdev port %u for NULL link\n", > >> + port_id); > >

Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Kevin Traynor
On 20/04/2021 11:04, Thomas Monjalon wrote: > Thanks for the work. > Few last comments below. > > 17/04/2021 09:39, Min Hu (Connor): >> @@ -293,6 +303,11 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, >> const char *devargs_str) >> uint16_t >> rte_eth_iterator_next(struct rte_dev_itera

Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Ferruh Yigit
On 4/20/2021 11:04 AM, Thomas Monjalon wrote: Thanks for the work. Few last comments below. 17/04/2021 09:39, Min Hu (Connor): @@ -293,6 +303,11 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str) uint16_t rte_eth_iterator_next(struct rte_dev_iterator *iter)

Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Thomas Monjalon
Thanks for the work. Few last comments below. 17/04/2021 09:39, Min Hu (Connor): > @@ -293,6 +303,11 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, > const char *devargs_str) > uint16_t > rte_eth_iterator_next(struct rte_dev_iterator *iter) > { > + if (iter == NULL) { > +

[dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-17 Thread Min Hu (Connor)
This patch adds more sanity checks in control path APIs. Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input") Fixes: 3d98f921fbe9 ("ethdev: unify prefix for static functions and variables") Fixes: 0366137722a0 ("ethdev: check for invalid device name") Fixes: d948f596fee2 ("ethdev: f