Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-04 Thread Zhang, Qi Z
in H ; Vangati, Narender > ; gaetan.ri...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on > multi-process > > 04/07/2018 04:26, Zhang, Qi Z: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 03/07/2018 23:57, Thomas Monjalon: > &g

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-04 Thread Thomas Monjalon
04/07/2018 04:26, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 03/07/2018 23:57, Thomas Monjalon: > > > 03/07/2018 17:03, Zhang, Qi Z: > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > > > > +do_eth_dev_attach(cons

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
in H ; Vangati, Narender > > Subject: Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on > multi-process > > 03/07/2018 23:57, Thomas Monjalon: > > 03/07/2018 17:03, Zhang, Qi Z: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > 03/07/2018 14:59,

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 23:57, Thomas Monjalon: > 03/07/2018 17:03, Zhang, Qi Z: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > > +do_eth_dev_attach(const char *devargs, uint16_t *port_id); > > > > > > > > > > So you are duplicating rte_eth_dev_attach which

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 17:03, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > +do_eth_dev_attach(const char *devargs, uint16_t *port_id); > > > > > > > > So you are duplicating rte_eth_dev_attach which is flawed in its > > > > design and should be

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
i, Narender > > Subject: Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on > multi-process > > 03/07/2018 14:59, Zhang, Qi Z: > > > > +/** > > > > + * this is a synchronous wrapper for secondary process send > > > > + * request to pr

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 14:59, Zhang, Qi Z: > > > +/** > > > + * this is a synchronous wrapper for secondary process send > > > + * request to primary process, this is invoked when an attach > > > + * or detach request issued from primary. > > > + */ > > > +int eth_dev_request_to_primary(struct eth_dev_mp_req *

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
Hi Thomas: <...> > > +enum eth_dev_req_type { > > + REQ_TYPE_ATTACH, > > + REQ_TYPE_PRE_DETACH, > > + REQ_TYPE_DETACH, > > + REQ_TYPE_ATTACH_ROLLBACK, > > +}; > > These constants are missing an ethdev prefix. OK, will fix. > > > + > > +struct eth_dev_mp_req { > > + enum eth_dev_req_t

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
Hi, 02/07/2018 07:44, Qi Zhang: > --- /dev/null > +++ b/lib/librte_ethdev/ethdev_mp.h > @@ -0,0 +1,41 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#ifndef _RTE_ETHDEV_MP_H_ > +#define _RTE_ETHDEV_MP_H_ > + > +#define MAX_DEV_ARGS_LEN 0x80 >

[dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-01 Thread Qi Zhang
We are going to introduce the solution to handle different hotplug cases in multi-process situation, it include below scenario: 1. Attach a share device from primary 2. Detach a share device from primary 3. Attach a share device from secondary 4. Detach a share device from secondary 5. Attach a pr