Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-02 Thread Anand Rawat
On 4/2/2019 3:39 PM, Thomas Monjalon wrote: I think the change below is bad because it is exposing an internal function in a header file which may be included by apps. I know you are still looking for pthread integration solutions, so we can discuss how to fix it later. Note that there is alread

Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-02 Thread Thomas Monjalon
I think the change below is bad because it is exposing an internal function in a header file which may be included by apps. I know you are still looking for pthread integration solutions, so we can discuss how to fix it later. Note that there is already an EAL function to create normal threads:

Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-02 Thread Pallavi Kadam
On 4/2/2019 2:38 PM, Thomas Monjalon wrote: 02/04/2019 23:21, Pallavi Kadam: On 4/2/2019 1:06 PM, Thomas Monjalon wrote: 02/04/2019 05:54, Anand Rawat: Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaract

Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-02 Thread Thomas Monjalon
02/04/2019 23:21, Pallavi Kadam: > > On 4/2/2019 1:06 PM, Thomas Monjalon wrote: > > 02/04/2019 05:54, Anand Rawat: > >> Add windows specific logic for eal.c, eal_lcore.c, > >> eal_debug.c and eal_thread.c. Updated header files to > >> contain suitable function declaractions. > >> > >> Signed-off-

Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-02 Thread Pallavi Kadam
On 4/2/2019 1:06 PM, Thomas Monjalon wrote: 02/04/2019 05:54, Anand Rawat: Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: J

Re: [dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-02 Thread Thomas Monjalon
02/04/2019 05:54, Anand Rawat: > Add windows specific logic for eal.c, eal_lcore.c, > eal_debug.c and eal_thread.c. Updated header files to > contain suitable function declaractions. > > Signed-off-by: Anand Rawat > Signed-off-by: Pallavi Kadam > Reviewed-by: Jeff Shaw > Reviewed-by: Ranjit Men

[dpdk-dev] [PATCH v8 08/10] eal: add minimum viable code for eal on windows

2019-04-01 Thread Anand Rawat
Add windows specific logic for eal.c, eal_lcore.c, eal_debug.c and eal_thread.c. Updated header files to contain suitable function declaractions. Signed-off-by: Anand Rawat Signed-off-by: Pallavi Kadam Reviewed-by: Jeff Shaw Reviewed-by: Ranjit Menon --- lib/librte_eal/windows/eal/eal.c