Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Lance Richardson
> First the code cause problem in the driver looks in another place, following > in > 'bnxt_mtu_set_op()': > >if (new_mtu > RTE_ETHER_MTU) { >bp->flags |= BNXT_FLAG_JUMBO; >bp->eth_dev->data->dev_conf.rxmode.offloads |= >

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Lance Richardson
nanyev, Konstantin > > > > > > > ; > > > > > > > Xing, Beilei ; Lu, Wenzhuo > > > > > > > ; > > > > > > > Iremonger, Bernard ; Yang, Qiming > > > > > > > ; m...@ashroe.eu; nhor...@tuxdri

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Ferruh Yigit
ee below. 05/11/2020 11:44, Thomas Monjalon: 05/11/2020 11:37, Ferruh Yigit: On 11/5/2020 9:33 AM, Yang, SteveX wrote: From: Andrew Rybchenko Sent: Thursday, November 5, 2020 4:54 PM To: Thomas Monjalon ; Yang, SteveX ; Yigit, Ferruh Cc: dev@dpdk.org; Ananyev, Konstantin ; Xing, Beilei ; Lu,

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Olivier Matz
> > > > > ; > > > > > > Iremonger, Bernard ; Yang, Qiming > > > > > > ; m...@ashroe.eu; nhor...@tuxdriver.com; > > > > > > david.march...@redhat.com > > > > > > Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: f

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Ferruh Yigit
march...@redhat.com Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets On 11/4/20 11:39 PM, Thomas Monjalon wrote: 04/11/2020 21:19, Ferruh Yigit: On 11/4/2020 5:55 PM, Thomas Monjalon wrote: 04/11/2020 18:07, Ferruh Yigit: On 11/4/2020 4:51 PM, Thomas Mon

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Ferruh Yigit
, Konstantin ; Xing, Beilei ; Lu, Wenzhuo ; Iremonger, Bernard ; Yang, Qiming ; m...@ashroe.eu; nhor...@tuxdriver.com; david.march...@redhat.com Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets On 11/4/20 11:39 PM, Thomas Monjalon wrote: 04/11/2020 21:19

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Thomas Monjalon
> >> Iremonger, Bernard ; Yang, Qiming > > >> ; m...@ashroe.eu; nhor...@tuxdriver.com; > > >> david.march...@redhat.com > > >> Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet > > >> length for VLAN packets > > >> >

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Thomas Monjalon
; Yigit, Ferruh > >> Cc: dev@dpdk.org; Ananyev, Konstantin ; > >> Xing, Beilei ; Lu, Wenzhuo ; > >> Iremonger, Bernard ; Yang, Qiming > >> ; m...@ashroe.eu; nhor...@tuxdriver.com; > >> david.march...@redhat.com > >> Subject: Re: [dpdk-dev

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Ferruh Yigit
...@ashroe.eu; nhor...@tuxdriver.com; david.march...@redhat.com Subject: Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets On 11/4/20 11:39 PM, Thomas Monjalon wrote: 04/11/2020 21:19, Ferruh Yigit: On 11/4/2020 5:55 PM, Thomas Monjalon wrote: 04/11/2020 18:07

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-05 Thread Andrew Rybchenko
On 11/4/20 11:39 PM, Thomas Monjalon wrote: > 04/11/2020 21:19, Ferruh Yigit: >> On 11/4/2020 5:55 PM, Thomas Monjalon wrote: >>> 04/11/2020 18:07, Ferruh Yigit: On 11/4/2020 4:51 PM, Thomas Monjalon wrote: > 03/11/2020 14:29, Ferruh Yigit: >> On 11/2/2020 11:48 AM, Ferruh Yigit wrote:

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Thomas Monjalon
04/11/2020 21:19, Ferruh Yigit: > On 11/4/2020 5:55 PM, Thomas Monjalon wrote: > > 04/11/2020 18:07, Ferruh Yigit: > >> On 11/4/2020 4:51 PM, Thomas Monjalon wrote: > >>> 03/11/2020 14:29, Ferruh Yigit: > On 11/2/2020 11:48 AM, Ferruh Yigit wrote: > > On 11/2/2020 8:52 AM, SteveX Yang wrot

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 5:55 PM, Thomas Monjalon wrote: 04/11/2020 18:07, Ferruh Yigit: On 11/4/2020 4:51 PM, Thomas Monjalon wrote: 03/11/2020 14:29, Ferruh Yigit: On 11/2/2020 11:48 AM, Ferruh Yigit wrote: On 11/2/2020 8:52 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Thomas Monjalon
04/11/2020 18:07, Ferruh Yigit: > On 11/4/2020 4:51 PM, Thomas Monjalon wrote: > > 03/11/2020 14:29, Ferruh Yigit: > >> On 11/2/2020 11:48 AM, Ferruh Yigit wrote: > >>> On 11/2/2020 8:52 AM, SteveX Yang wrote: > When the max rx packet length is smaller than the sum of mtu size and > ether

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Ferruh Yigit
On 11/4/2020 4:51 PM, Thomas Monjalon wrote: 03/11/2020 14:29, Ferruh Yigit: On 11/2/2020 11:48 AM, Ferruh Yigit wrote: On 11/2/2020 8:52 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-04 Thread Thomas Monjalon
03/11/2020 14:29, Ferruh Yigit: > On 11/2/2020 11:48 AM, Ferruh Yigit wrote: > > On 11/2/2020 8:52 AM, SteveX Yang wrote: > >> When the max rx packet length is smaller than the sum of mtu size and > >> ether overhead size, it should be enlarged, otherwise the VLAN packets > >> will be dropped. > >>

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-03 Thread Ferruh Yigit
On 11/2/2020 11:48 AM, Ferruh Yigit wrote: On 11/2/2020 8:52 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether de

Re: [dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-02 Thread Ferruh Yigit
On 11/2/2020 8:52 AM, SteveX Yang wrote: When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Signed-off-by: SteveX Yang Revie

[dpdk-dev] [PATCH v8 1/2] app/testpmd: fix max rx packet length for VLAN packets

2020-11-02 Thread SteveX Yang
When the max rx packet length is smaller than the sum of mtu size and ether overhead size, it should be enlarged, otherwise the VLAN packets will be dropped. Fixes: 35b2d13fd6fd ("net: add rte prefix to ether defines") Signed-off-by: SteveX Yang --- app/test-pmd/testpmd.c | 23 +