Re: [dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined meter policy API

2021-04-19 Thread Jiawei(Jonny) Wang
Thanks Jasvinder's comments! Li is on vacation so I help to update the code changes based on your comments, V9 is sent with your ack. > -Original Message- > From: Singh, Jasvinder > Sent: Monday, April 19, 2021 8:35 PM > To: Li Zhang ; dek...@nvidia.com; Ori Kam > ; Slava Ovsiienko ; Mat

Re: [dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined meter policy API

2021-04-19 Thread Singh, Jasvinder
> +/* MTR meter policy add */ > +static int > +pmd_mtr_meter_policy_add(struct rte_eth_dev *dev, > + uint32_t meter_policy_id, > + struct rte_mtr_meter_policy_params *policy, > + struct rte_mtr_error *error) > +{ > + struct pmd_internals *p = dev->data->dev_private; > + struct

Re: [dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined meter policy API

2021-04-15 Thread Ori Kam
Hi Li > -Original Message- > From: Li Zhang > Sent: Thursday, April 15, 2021 12:20 PM > Subject: [PATCH v8 1/2] ethdev: add pre-defined meter policy API > > Currently, the flow meter policy does not support multiple actions > per color; also the allowed action types per color are very li

[dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined meter policy API

2021-04-15 Thread Li Zhang
Currently, the flow meter policy does not support multiple actions per color; also the allowed action types per color are very limited. In addition, the policy cannot be pre-defined. Due to the growing in flow actions offload abilities there is a potential for the user to use variety of actions pe