[dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function name of tunnel port config

2016-03-10 Thread Lu, Wenzhuo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, March 9, 2016 5:49 PM > To: Lu, Wenzhuo > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function name > of tunnel

[dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function name of tunnel port config

2016-03-09 Thread Wenzhuo Lu
The names of function for tunnel port configuration are not accurate. They're tunnel_add/del, better change them to tunnel_port_add/del. As it may be an ABI change if change the names directly, the new functions are added but not remove the old ones. The old ones will be removed in the next

[dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function name of tunnel port config

2016-03-09 Thread Thomas Monjalon
2016-03-09 11:35, Wenzhuo Lu: > + uint16_t udp_port; /**< UDP port used for the tunnel. */ > + uint8_t prot_type; /**< Tunnel type. */ Is 42 a valid tunnel type? Please reference where to find the constants. Think as a user who won't read your datasheet. [...] > /** > - * Add UDP