Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Thomas Monjalon
14/04/2019 20:19, Jerin Jacob Kollanukkaran: > From: Thomas Monjalon > > 14/04/2019 16:40, Pavan Nikhilesh Bhagavatula: > > > Hi Thomas, > > > > > > There is no guarantee of primary part number (machine names) uniqueness > > between implementors. > > > > I think we don't speak the same language :

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Jerin Jacob Kollanukkaran
t; /"cross" build, "distribution" build, cache line differences etc, makes it bit difficult. But if you think, it can be improved. Please share patch, We are happy to review and test in the platforms we have. > > I think from a configurability point of view the above three a

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Thomas Monjalon
karan > >Cc: Pavan Nikhilesh Bhagavatula ; > >dev@dpdk.org; jerinjac...@gmail.com; ys...@mellanox.com; > >bruce.richard...@intel.com > >Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine > >specific flags > > > >13/04/2019 08:24, Jerin Jacob

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-14 Thread Pavan Nikhilesh Bhagavatula
om; >bruce.richard...@intel.com >Subject: Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine >specific flags > >13/04/2019 08:24, Jerin Jacob Kollanukkaran: >> > I was not confortable with this patch without being able to say why. >> > Yesterday

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-13 Thread Thomas Monjalon
13/04/2019 08:24, Jerin Jacob Kollanukkaran: > > I was not confortable with this patch without being able to say why. > > Yesterday I spent more time to understand and see what may be improved. > > I agree it is late, so it won't block this patch for 19.05. > > Do you agree this file can be improve

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> > > > +machine_args_cavium = [ > > > > + ['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']], > > > > + ['native', ['-march=native']], > > > > + ['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra], > > > > + ['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Thomas Monjalon
12/04/2019 09:12, Jerin Jacob Kollanukkaran: > From: Thomas Monjalon > > 10/04/2019 18:13, jerinjac...@gmail.com: > > > From: Pavan Nikhilesh > > > > > > Currently, RTE_* flags are set based on the implementer ID but there > > > might be some micro arch specific differences from the same vendor e

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Yongseok Koh
>> Monjalon ; dev ; >> jerinjac...@gmail.com >> Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support >> machine specific flags >> >> >> >> One more issue. >> With gcc7.2, crypto isn't enabled if -mcpu is set. >&g

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, April 12, 2019 12:39 PM > To: Jerin Jacob Kollanukkaran > Cc: Pavan Nikhilesh Bhagavatula ; Thomas > Monjalon ; dev ; > jerinjac...@gmail.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add in

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Yongseok Koh
gt; Monjalon ; dev ; >> jerinjac...@gmail.com >> Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support >> machine specific flags >> >> >> Thanks, that fixes the issue. >> But I've encountered another one. Are you aware of this? > >

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Thomas Monjalon > Sent: Friday, April 12, 2019 5:07 AM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran > Cc: dev@dpdk.org; jerinjac...@gmail.com; ys...@mellanox.com; > bruce.richard...@intel.com > Subject: Re: [dpdk-d

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Yongseok Koh
, 2019 7:35 AM >>> To: Pavan Nikhilesh Bhagavatula >>> Cc: Thomas Monjalon ; dev ; Jerin >>> Jacob Kollanukkaran ; jerinjac...@gmail.com >>> Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support >>> machine specific flags >>&

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-12 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, April 12, 2019 12:14 PM > To: Jerin Jacob Kollanukkaran > Cc: Pavan Nikhilesh Bhagavatula ; Thomas > Monjalon ; dev ; > jerinjac...@gmail.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add in

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
gt;> Jacob Kollanukkaran ; jerinjac...@gmail.com >> Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support >> machine specific flags >> >> External Email >> >> I've tested it but still have an issue with old gcc. >> Even if -mcpu isn

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Friday, April 12, 2019 7:35 AM > To: Pavan Nikhilesh Bhagavatula > Cc: Thomas Monjalon ; dev ; Jerin > Jacob Kollanukkaran ; jerinjac...@gmail.com > Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
ednesday, April 10, 2019 11:08 PM >>> To: Pavan Nikhilesh Bhagavatula >>> Cc: Thomas Monjalon ; dev ; Jerin >>> Jacob Kollanukkaran ; jerinjac...@gmail.com >>> Subject: [EXT] Re:

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
> On Apr 11, 2019, at 4:37 PM, Thomas Monjalon wrote: > > 10/04/2019 18:13, jerinjac...@gmail.com: >> From: Pavan Nikhilesh >> >> Currently, RTE_* flags are set based on the implementer ID but there might >> be some micro arch specific differences from the same vendor >> eg. CACHE_LINESIZE. A

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Thomas Monjalon
10/04/2019 18:13, jerinjac...@gmail.com: > From: Pavan Nikhilesh > > Currently, RTE_* flags are set based on the implementer ID but there might > be some micro arch specific differences from the same vendor > eg. CACHE_LINESIZE. Add support to set micro arch specific flags. I don't like how flag

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-11 Thread Yongseok Koh
dev ; Jerin >> Jacob Kollanukkaran ; jerinjac...@gmail.com >> Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support >> machine specific flags >> >> External Email >> >> ---

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-10 Thread Pavan Nikhilesh Bhagavatula
Hi Yongseok, >-Original Message- >From: Yongseok Koh >Sent: Wednesday, April 10, 2019 11:08 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Thomas Monjalon ; dev ; Jerin >Jacob Kollanukkaran ; jerinjac...@gmail.com >Subject: [EXT] Re: [dpdk-dev] [PATCH v8 2/4] meson:

Re: [dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-10 Thread Yongseok Koh
> On Apr 10, 2019, at 9:13 AM, jerinjac...@gmail.com wrote: > > From: Pavan Nikhilesh > > Currently, RTE_* flags are set based on the implementer ID but there might > be some micro arch specific differences from the same vendor > eg. CACHE_LINESIZE. Add support to set micro arch specific flags

[dpdk-dev] [PATCH v8 2/4] meson: add infra to support machine specific flags

2019-04-10 Thread jerinjacobk
From: Pavan Nikhilesh Currently, RTE_* flags are set based on the implementer ID but there might be some micro arch specific differences from the same vendor eg. CACHE_LINESIZE. Add support to set micro arch specific flags. Signed-off-by: Pavan Nikhilesh Signed-off-by: Jerin Jacob --- config/