Re: [dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests

2019-04-30 Thread Thomas Monjalon
30/04/2019 06:20, Honnappa Nagarahalli: > > > > Please, could you check details like alignment or alphabetical sorting? > I don't see any alignment issues (there is mixed use of tabs and spaces in > this file, will use the same). > > > Thanks > > > > 26/04/2019 06:39, Honnappa Nagarahalli: > >

Re: [dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests

2019-04-29 Thread Honnappa Nagarahalli
> > Please, could you check details like alignment or alphabetical sorting? I don't see any alignment issues (there is mixed use of tabs and spaces in this file, will use the same). > Thanks > > 26/04/2019 06:39, Honnappa Nagarahalli: > > --- a/app/test/meson.build > > +++ b/app/test/meson.buil

Re: [dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests

2019-04-29 Thread Thomas Monjalon
Please, could you check details like alignment or alphabetical sorting? Thanks 26/04/2019 06:39, Honnappa Nagarahalli: > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -111,6 +111,8 @@ test_sources = files('commands.c', > 'test_timer_racecond.c', > 'test_timer_seconda

[dpdk-dev] [PATCH v8 2/4] test/rcu_qsbr: add API and functional tests

2019-04-25 Thread Honnappa Nagarahalli
From: Dharmik Thakkar Add API positive/negative test cases, functional tests and performance tests. Signed-off-by: Malvika Gupta Signed-off-by: Dharmik Thakkar Signed-off-by: Honnappa Nagarahalli Reviewed-by: Gavin Hu Acked-by: Konstantin Ananyev --- app/test/Makefile |2 +