[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 11:42:24AM +0200, Michael S. Tsirkin wrote: ... > > > Looking at that, at least when MQ is enabled, please don't key > > > stopping queues off GET_VRING_BASE. > > > > Yes, that's only a workaround. I guess it has been there for quite a > > while, maybe at the time qemu

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Yuanhan Liu
On Tue, Oct 27, 2015 at 11:17:16AM +0200, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2015 at 03:20:40PM +0900, Tetsuya Mukawa wrote: > > On 2015/10/26 14:42, Yuanhan Liu wrote: > > > On Mon, Oct 26, 2015 at 02:24:08PM +0900, Tetsuya Mukawa wrote: > > >> On 2015/10/22 21:35, Yuanhan Liu wrote: > >

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Tetsuya Mukawa
On 2015/10/26 14:42, Yuanhan Liu wrote: > On Mon, Oct 26, 2015 at 02:24:08PM +0900, Tetsuya Mukawa wrote: >> On 2015/10/22 21:35, Yuanhan Liu wrote: > ... >>> @@ -292,13 +300,13 @@ user_get_vring_base(struct vhost_device_ctx ctx, >>> * sent and only sent in vhost_vring_stop. >>> * TODO:

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 10:51:14AM +0100, Thomas Monjalon wrote: > 2015-10-27 11:42, Michael S. Tsirkin: > > On Tue, Oct 27, 2015 at 05:30:41PM +0800, Yuanhan Liu wrote: > > > On Tue, Oct 27, 2015 at 11:17:16AM +0200, Michael S. Tsirkin wrote: > > > > Looking at that, at least when MQ is enabled,

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 05:30:41PM +0800, Yuanhan Liu wrote: > On Tue, Oct 27, 2015 at 11:17:16AM +0200, Michael S. Tsirkin wrote: > > On Tue, Oct 27, 2015 at 03:20:40PM +0900, Tetsuya Mukawa wrote: > > > On 2015/10/26 14:42, Yuanhan Liu wrote: > > > > On Mon, Oct 26, 2015 at 02:24:08PM +0900,

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Michael S. Tsirkin
On Tue, Oct 27, 2015 at 03:20:40PM +0900, Tetsuya Mukawa wrote: > On 2015/10/26 14:42, Yuanhan Liu wrote: > > On Mon, Oct 26, 2015 at 02:24:08PM +0900, Tetsuya Mukawa wrote: > >> On 2015/10/22 21:35, Yuanhan Liu wrote: > > ... > >>> @@ -292,13 +300,13 @@ user_get_vring_base(struct vhost_device_ctx

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Thomas Monjalon
2015-10-27 11:42, Michael S. Tsirkin: > On Tue, Oct 27, 2015 at 05:30:41PM +0800, Yuanhan Liu wrote: > > On Tue, Oct 27, 2015 at 11:17:16AM +0200, Michael S. Tsirkin wrote: > > > Looking at that, at least when MQ is enabled, please don't key > > > stopping queues off GET_VRING_BASE. > > > > Yes,

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-27 Thread Xie, Huawei
On 10/27/2015 5:56 PM, Michael S. Tsirkin wrote: > On Tue, Oct 27, 2015 at 10:51:14AM +0100, Thomas Monjalon wrote: >> 2015-10-27 11:42, Michael S. Tsirkin: >>> On Tue, Oct 27, 2015 at 05:30:41PM +0800, Yuanhan Liu wrote: On Tue, Oct 27, 2015 at 11:17:16AM +0200, Michael S. Tsirkin wrote:

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-26 Thread Tetsuya Mukawa
On 2015/10/22 21:35, Yuanhan Liu wrote: > All queue pairs, including the default (the first) queue pair, > are allocated dynamically, when a vring_call message is received > first time for a specific queue pair. > > This is a refactor work for enabling vhost-user multiple queue; > it should not

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-26 Thread Yuanhan Liu
On Mon, Oct 26, 2015 at 02:24:08PM +0900, Tetsuya Mukawa wrote: > On 2015/10/22 21:35, Yuanhan Liu wrote: ... > > @@ -292,13 +300,13 @@ user_get_vring_base(struct vhost_device_ctx ctx, > > * sent and only sent in vhost_vring_stop. > > * TODO: cleanup the vring, it isn't usable since

[dpdk-dev] [PATCH v8 3/8] vhost: vring queue setup for multiple queue support

2015-10-22 Thread Yuanhan Liu
All queue pairs, including the default (the first) queue pair, are allocated dynamically, when a vring_call message is received first time for a specific queue pair. This is a refactor work for enabling vhost-user multiple queue; it should not break anything as it does no functional changes: we