Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Ye Xiaolong
On 11/08, Thomas Monjalon wrote: >Hi, > >I see this patch is already merged in next-net-intel, >but please I would prefer to have below improvements first. > Got it, I'll drop v9 in next-net-intel and wait for the improved new version. Thanks, Xiaolong

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Wang, Haiyue
> -Original Message- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 22:40 > To: Wang, Haiyue > Cc: dev@dpdk.org; olivier.m...@6wind.com; Ye, Xiaolong > ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by &g

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
> > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by > > dynamic mbuf API > > > > Hi, > > > > I see this patch is already merged in next-net-intel, > > but please I would prefer to have below improvements first. > >

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
08/11/2019 15:01, Wang, Haiyue: > From: Thomas Monjalon > > 07/11/2019 11:44, Haiyue Wang: > > > --- a/drivers/net/ice/rte_pmd_ice_version.map > > > +++ b/drivers/net/ice/rte_pmd_ice_version.map > > > +EXPERIMENTAL { > > > + global: > > > + > > > + # added in 19.11 > > > + rte_net_ice_dynfield_pro

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Wang, Haiyue
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 20:34 > To: Wang, Haiyue > Cc: dev@dpdk.org; olivier.m...@6wind.com; Ye, Xiaolong > ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extra

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Wang, Haiyue
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Friday, November 8, 2019 20:55 > To: Wang, Haiyue > Cc: dev@dpdk.org; olivier.m...@6wind.com; Ye, Xiaolong > ; Yigit, Ferruh > > Subject: Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extra

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
07/11/2019 11:44, Haiyue Wang: > --- a/drivers/net/ice/rte_pmd_ice_version.map > +++ b/drivers/net/ice/rte_pmd_ice_version.map > +EXPERIMENTAL { > + global: > + > + # added in 19.11 > + rte_net_ice_dynfield_proto_xtr_metadata_offs; > + rte_net_ice_dynflag_proto_xtr_vlan_mask; > +

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-08 Thread Thomas Monjalon
Hi, I see this patch is already merged in next-net-intel, but please I would prefer to have below improvements first. 07/11/2019 11:44, Haiyue Wang: > The original design is to use rte_mbuf::udata64 to save the metadata of > protocol extraction which has network protocol data fields and type, a >

Re: [dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-07 Thread Ye Xiaolong
On 11/07, Haiyue Wang wrote: >The original design is to use rte_mbuf::udata64 to save the metadata of >protocol extraction which has network protocol data fields and type, a >private API is used to decode this metadata. > >Use the dynamic mbuf field and flags to register the needed fields in >mbuf,

[dpdk-dev] [PATCH v9] net/ice: optimize protocol extraction by dynamic mbuf API

2019-11-07 Thread Haiyue Wang
The original design is to use rte_mbuf::udata64 to save the metadata of protocol extraction which has network protocol data fields and type, a private API is used to decode this metadata. Use the dynamic mbuf field and flags to register the needed fields in mbuf, to avoid overwriting 'rte_mbuf::ud