Re: [dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in device detach

2017-01-18 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 4:43 PM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v9 04/12] eal: remove loop over drivers in device detach > > 2017-01-18 16:07, Shreyansh Jain: > > +

Re: [dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in device detach

2017-01-18 Thread Thomas Monjalon
2017-01-18 16:07, Shreyansh Jain: > + dr = dev->driver; > + > ret = rte_pci_match(dr, dev); > I think you don't need to match driver anymore.

Re: [dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in device detach

2017-01-18 Thread Shreyansh Jain
Thomas, On Wednesday 18 January 2017 04:07 PM, Shreyansh Jain wrote: diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c index 4f155c6..7548ab0 100644 --- a/lib/librte_eal/common/eal_common_pci.c +++ b/lib/librte_eal/common/eal_common_pci.c @@ -259,15 +2

[dpdk-dev] [PATCH v9 04/12] eal: remove loop over drivers in device detach

2017-01-18 Thread Shreyansh Jain
rte_eal_pci_detach calls pci_detach_all_drivers which loops over all PCI drivers for detaching the device. This is unnecessary as the device already has the PCI driver reference which can be used directly. Removing pci_detach_all_drivers and restructuring rte_eal_pci_detach and rte_eal_pci_detach_