[dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev

2018-04-25 Thread Arnon Warshavsky
Local function to this file, changing from void to int is non-abi-breaking Signed-off-by: Arnon Warshavsky --- lib/librte_ether/rte_ethdev.c | 42 ++ lib/librte_ether/rte_ethdev.h | 4 +++- 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/

Re: [dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev

2018-04-26 Thread Kevin Traynor
On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > Local function to this file, > changing from void to int is non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_ether/rte_ethdev.c | 42 ++ > lib/librte_ether/rte_ethdev.h | 4 +++- > 2

Re: [dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev

2018-04-26 Thread Arnon Warshavsky
> > -void __rte_experimental > > +int __rte_experimental > > rte_eth_dev_owner_delete(const uint64_t owner_id) > > { > > uint16_t port_id; > > + int error; > > it's inconsistent that this function returns the error code from > rte_eth_dev_shared_data_prepare() and all these other functi