Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-27 Thread Kevin Traynor
On 04/26/2018 11:08 PM, Arnon Warshavsky wrote: > Hi Kevin > > > + if (rte_config_init() != 0) > > + return -1; > > + > > I'm confused, is this deliberate? there is now two rte_config_init() > calls. > > > Please note that there are 2 eal.c files. One under

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-26 Thread Arnon Warshavsky
On Fri, Apr 27, 2018 at 1:08 AM, Arnon Warshavsky wrote: > Hi Kevin > >> > + if (rte_config_init() != 0) >> > + return -1; >> > + >> >> I'm confused, is this deliberate? there is now two rte_config_init() >> calls. > > > Please note that there are 2 eal.c files. One under linux an

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-26 Thread Arnon Warshavsky
Hi Kevin > > + if (rte_config_init() != 0) > > + return -1; > > + > > I'm confused, is this deliberate? there is now two rte_config_init() > calls. Please note that there are 2 eal.c files. One under linux and one under bsd There is a copy of rte_config_init() in each. > Aaron'

Re: [dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-26 Thread Kevin Traynor
On 04/26/2018 07:21 AM, Arnon Warshavsky wrote: > Change some local functions return type from void to int. > This change does not break ABI as the functions are internal. > Panic thrown from threads was not handled in this patch > > Signed-off-by: Arnon Warshavsky > Acked-by: Anatoly Burakov >

[dpdk-dev] [PATCH v9 09/10] eal: replace rte_panic instances in init sequence

2018-04-25 Thread Arnon Warshavsky
Change some local functions return type from void to int. This change does not break ABI as the functions are internal. Panic thrown from threads was not handled in this patch Signed-off-by: Arnon Warshavsky Acked-by: Anatoly Burakov --- lib/librte_eal/bsdapp/eal/eal.c | 71 +