[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-10-12 Thread Ilya Maximets
Sorry for pinging, but have you tried to merge this patch? Best regards, Ilya Maximets. On 02.10.2015 14:25, Wiles, Keith wrote: > I looked at the code and everything looks good. I will try to merge the > code next week as I am traveling again :-( > > Thanks for the patch, I am glad you found

[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-10-02 Thread Ilya Maximets
Ping. On 17.09.2015 08:55, Ilya Maximets wrote: > Ok. Thank you. I'll wait. > > On 16.09.2015 18:37, Wiles, Keith wrote: >> Thanks the patch looks fine, but I have not had a lot of time to review it >> detail. I hope to get to it next week after I return back home. >> >> On 9/16/15, 2:09 AM,

[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-10-02 Thread Wiles, Keith
I looked at the code and everything looks good. I will try to merge the code next week as I am traveling again :-( Thanks for the patch, I am glad you found this problem as I believe someone else reported something odd in that area, but was not able to give me many details. ? Regards, ++Keith

[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-09-17 Thread Ilya Maximets
Ok. Thank you. I'll wait. On 16.09.2015 18:37, Wiles, Keith wrote: > Thanks the patch looks fine, but I have not had a lot of time to review it > detail. I hope to get to it next week after I return back home. > > On 9/16/15, 2:09 AM, "Ilya Maximets" wrote: > >> Ping. >> >> On 09.09.2015

[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-09-16 Thread Wiles, Keith
Thanks the patch looks fine, but I have not had a lot of time to review it detail. I hope to get to it next week after I return back home. On 9/16/15, 2:09 AM, "Ilya Maximets" wrote: >Ping. > >On 09.09.2015 17:22, Ilya Maximets wrote: >> While pktgen_setup_packets() all threads of one port uses

[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-09-16 Thread Ilya Maximets
Ping. On 09.09.2015 17:22, Ilya Maximets wrote: > While pktgen_setup_packets() all threads of one port uses same > info->seq_pkt. This leads to constructing packets in the same memory region > (>hdr). As a result, pktgen_setup_packets generates random headers. > > Fix that by making a local copy

[dpdk-dev] [Pktgen] [PATCH] pktgen_setup_packets: fix race for packet header

2015-09-09 Thread Ilya Maximets
While pktgen_setup_packets() all threads of one port uses same info->seq_pkt. This leads to constructing packets in the same memory region (>hdr). As a result, pktgen_setup_packets generates random headers. Fix that by making a local copy of info->seq_pkt and using it for constructing of packets.