Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-04 Thread Gregory Etelson
Hello Jianfeng, I was experimenting with pci_disable_device() in release Tests running on Intel 82599 VF crashed server after process down, before a new instance was started. Tests running on Intel XL710 VF did not crash server, but could not send / receive Ethernet frames although all DPDK initi

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-04 Thread Tan, Jianfeng
Hi Gregory, On 6/4/2017 3:22 PM, Gregory Etelson wrote: In my environment I could reproduce server crash after applying the patch Different from your patch, my patch calls pci_enable_device()/pci_disable_device() instead of pci_reset_function()/pci_try_reset_function() separately in open

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-04 Thread Gregory Etelson
In my environment I could reproduce server crash after applying the patch Regards, Gregory On Wednesday, 31 May 2017 15:20:08 IDT Ferruh Yigit wrote: > On 5/31/2017 12:09 PM, Shijith Thotton wrote: > > Set UIO info device file operations open and release. Call pci reset > > function inside open

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-01 Thread Shijith Thotton
On Wed, May 31, 2017 at 06:11:40PM +0100, Ferruh Yigit wrote: > On 5/31/2017 4:30 PM, Stephen Hemminger wrote: > > On Wed, 31 May 2017 13:20:08 +0100 > > Ferruh Yigit wrote: > > > >> On 5/31/2017 12:09 PM, Shijith Thotton wrote: > >>> Set UIO info device file operations open and release. Call pci

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-06-01 Thread Gregory Etelson
On Wednesday, 31 May 2017 15:20:08 IDT Ferruh Yigit wrote: > On 5/31/2017 12:09 PM, Shijith Thotton wrote: > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and > > end. Copied this behaviour from vfio_pci k

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-05-31 Thread Ferruh Yigit
On 5/31/2017 4:30 PM, Stephen Hemminger wrote: > On Wed, 31 May 2017 13:20:08 +0100 > Ferruh Yigit wrote: > >> On 5/31/2017 12:09 PM, Shijith Thotton wrote: >>> Set UIO info device file operations open and release. Call pci reset >>> function inside open and release to clear device state at start

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-05-31 Thread Stephen Hemminger
On Wed, 31 May 2017 13:20:08 +0100 Ferruh Yigit wrote: > On 5/31/2017 12:09 PM, Shijith Thotton wrote: > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and > > end. Copied this behaviour from vfio_pci kern

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-05-31 Thread Stephen Hemminger
On Wed, 31 May 2017 16:39:26 +0530 Shijith Thotton wrote: > + /* reset the pci device */ > + pci_reset_function(dev); It is not considered best practice to comment the obvious. This comment borders on being the classic /* add one to i */

Re: [dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-05-31 Thread Ferruh Yigit
On 5/31/2017 12:09 PM, Shijith Thotton wrote: > Set UIO info device file operations open and release. Call pci reset > function inside open and release to clear device state at start and > end. Copied this behaviour from vfio_pci kernel module code. With this > change, it is not mandatory to issue

[dpdk-dev] [RFC PATCH] igb_uio: issue FLR during open and release of device file

2017-05-31 Thread Shijith Thotton
Set UIO info device file operations open and release. Call pci reset function inside open and release to clear device state at start and end. Copied this behaviour from vfio_pci kernel module code. With this change, it is not mandatory to issue FLR by PMD's during init and close. Signed-off-by: Sh