Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-29 Thread David Marchand
On Fri, Nov 29, 2019 at 12:43 PM Neil Horman wrote: > > On Wed, Nov 27, 2019 at 09:45:46PM +0100, David Marchand wrote: > > On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote: > > > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > > > So far, we did not pay attention to direct a

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-29 Thread Neil Horman
On Wed, Nov 27, 2019 at 09:45:46PM +0100, David Marchand wrote: > On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote: > > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > > So far, we did not pay attention to direct access to variables but they > > > are part of the API/ABI too a

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-27 Thread David Marchand
On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote: > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > So far, we did not pay attention to direct access to variables but they > > are part of the API/ABI too and should be clearly identified. > > > > Introduce a __rte_experimental_

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread Neil Horman
On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > So far, we did not pay attention to direct access to variables but they > are part of the API/ABI too and should be clearly identified. > > Introduce a __rte_experimental_var tag and mark existing variables. > > Fixes: a4bcd61de82d

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread Neil Horman
On Tue, Nov 26, 2019 at 09:25:49AM +, Ray Kinsella wrote: > > My 2c is that it feels a little unweildy to have to annotate, every variable > declaration. > and also extern reference with __rte_experimental_var. > > Is there any easier way? > Note, just to be clear, its not every variable, o

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread David Marchand
On Tue, Nov 26, 2019 at 10:26 AM Ray Kinsella wrote: > > > My 2c is that it feels a little unweildy to have to annotate, every variable > declaration. > and also extern reference with __rte_experimental_var. > > Is there any easier way? We use this framework so that the users are aware they are

Re: [dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-26 Thread Ray Kinsella
My 2c is that it feels a little unweildy to have to annotate, every variable declaration. and also extern reference with __rte_experimental_var. Is there any easier way? Other minor comments below. On 25/11/2019 16:13, David Marchand wrote: > So far, we did not pay attention to direct access

[dpdk-dev] [RFC PATCH] mark experimental variables

2019-11-25 Thread David Marchand
So far, we did not pay attention to direct access to variables but they are part of the API/ABI too and should be clearly identified. Introduce a __rte_experimental_var tag and mark existing variables. Fixes: a4bcd61de82d ("buildtools: add script to check experimental API exports") Cc: sta...@dpd