Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-11-01 Thread Akhil Goyal
Hi Konstantin, > > > Hi Akhil, > > > > > > > Added my comments inline with your draft. > > > > > > [snip].. > > > > > > > > > > > > > > > > > > > > Ok, then my suggestion: > > > > > > > Let's at least write down all points about crypto-dev approach > > > > > > > where > we > > > > > > > disagr

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-30 Thread Ananyev, Konstantin
Hi Akhil, > > > > > Added my comments inline with your draft. > > > > > [snip].. > > > > > > > > > > > > > > > > > Ok, then my suggestion: > > > > > > Let's at least write down all points about crypto-dev approach > > > > > > where we > > > > > > disagree and then probably try to resolve them o

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-23 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > Added my comments inline with your draft. > > > > [snip].. > > > > > > > > > > > > > > Ok, then my suggestion: > > > > > Let's at least write down all points about crypto-dev approach where > > > > > we > > > > > disagree and then probably try to resol

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-22 Thread Ananyev, Konstantin
> > > > Added my comments inline with your draft. > > > > [snip].. > > > > > > > > > > > > > > Ok, then my suggestion: > > > > > Let's at least write down all points about crypto-dev approach where > > > > > we > > > > > disagree and then probably try to resolve them one by one > > > > > If we

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-22 Thread Ananyev, Konstantin
Hi Akhil, > > > Added my comments inline with your draft. > > > [snip].. > > > > > > > > > > > Ok, then my suggestion: > > > > Let's at least write down all points about crypto-dev approach where we > > > > disagree and then probably try to resolve them one by one > > > > If we fail to make

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-22 Thread Akhil Goyal
Hi Konstantin, > > > Hi Akhil, > > > > Added my comments inline with your draft. > > [snip].. > > > > > > > > Ok, then my suggestion: > > > Let's at least write down all points about crypto-dev approach where we > > > disagree and then probably try to resolve them one by one > > > If we f

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-21 Thread Ananyev, Konstantin
Hi Akhil, > Added my comments inline with your draft. > > > > > > Hi Akhil, > > > > > > BTW, to be honest, I don't consider current rte_cryptodev_sym_session > > > > construct for multiple device_ids: > > > > __extension__ struct { > > > > void *data; > > > > ui

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-18 Thread Akhil Goyal
Hi Konstantin, Added my comments inline with your draft. > > > Hi Akhil, > > > > BTW, to be honest, I don't consider current rte_cryptodev_sym_session > > > construct for multiple device_ids: > > > __extension__ struct { > > > void *data; > > > uint16_t refcnt; >

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-17 Thread Ananyev, Konstantin
> > > > > User can use the same session, that is what I am also insisting, but it > > > > may have > > > separate > > > > Session private data. Cryptodev session create API provide that > > > > functionality > > > and we can > > > > Leverage that. > > > > > > rte_cryptodev_sym_session. sess_da

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-16 Thread Ananyev, Konstantin
Hi Akhil, > > > User can use the same session, that is what I am also insisting, but it > > > may have > > separate > > > Session private data. Cryptodev session create API provide that > > > functionality > > and we can > > > Leverage that. > > > > rte_cryptodev_sym_session. sess_data[] is in

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-16 Thread Ananyev, Konstantin
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Tuesday, October 15, 2019 4:02 PM > To: Ananyev, Konstantin ; Zhang, Roy Fan > ; 'dev@dpdk.org' ; > De Lara Guarch, Pablo ; 'Thomas Monjalon' > ; Doherty, Declan > > Cc: 'Anoob Joseph' ; Jerin Jacob ; > Hem

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-15 Thread Akhil Goyal
> > > > Hi Akhil, > > > > Thanks for the review and comments! > > Knowing you are extremely busy. Here is my point in brief: > > I think placing the CPU synchronous crypto in the rte_security make sense, > > as > > > > 1. rte_security contains inline crypto and lookaside crypto action type >

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-15 Thread Akhil Goyal
Hi Fan, > > Hi Akhil, > > Thanks for the review and comments! > Knowing you are extremely busy. Here is my point in brief: > I think placing the CPU synchronous crypto in the rte_security make sense, as > > 1. rte_security contains inline crypto and lookaside crypto action type > already, > ad

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-14 Thread Ananyev, Konstantin
> Hi Akhil, > > Thanks for the review and comments! > Knowing you are extremely busy. Here is my point in brief: > I think placing the CPU synchronous crypto in the rte_security make sense, as > > 1. rte_security contains inline crypto and lookaside crypto action type > already, adding cpu_cry

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-13 Thread Zhang, Roy Fan
Hi Akhil, Thanks for the review and comments! Knowing you are extremely busy. Here is my point in brief: I think placing the CPU synchronous crypto in the rte_security make sense, as 1. rte_security contains inline crypto and lookaside crypto action type already, adding cpu_crypto action type i

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-11 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > ..[snip] > > > > > > OK let us assume that you have a separate structure. But I have a > > > > > > few > > > queries: > > > > > > 1. how can multiple drivers use a same session > > > > > > > > > > As a short answer: they can't. > > > > > It is pretty much the sam

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-09 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > > > > > > > This action type allows the burst of > > > > > > > > > > > > > > > > > symmetric crypto > > > > > > workload > > > > > > > > using > > > > > > > > > > > the > > > > > > > > > > > > > > > same > > > > > > > > > > > > > > > > > algorithm, key, and direc

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-09 Thread Akhil Goyal
Hi Konstantin, > > > Hi Akhil, > > > > > > > > > > > > > > > > > This action type allows the burst of symmetric > > > > > > > > > > > > > > > > crypto > > > > > workload > > > > > > > using > > > > > > > > > > the > > > > > > > > > > > > > > same > > > > > > > > > > > > > > > > algorithm, key,

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-07 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > > > > > This action type allows the burst of symmetric > > > > > > > > > > > > > > > crypto > > > > workload > > > > > > using > > > > > > > > > the > > > > > > > > > > > > > same > > > > > > > > > > > > > > > algorithm, key, and direction being processed by > >

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-03 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > > > > > > > > > > This action type allows the burst of symmetric > > > > > > > > > > > > > > crypto > > > workload > > > > > using > > > > > > > > the > > > > > > > > > > > > same > > > > > > > > > > > > > > algorithm, key, and direction being processed

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-10-01 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > > > This action type allows the burst of symmetric crypto > > workload > > > > using > > > > > > > the > > > > > > > > > > > same > > > > > > > > > > > > > algorithm, key, and direction being processed by CPU > > > > > > > > > > > > > cycles > > > > > > > > > syn

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-30 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > > > > > > > > This action type allows the burst of symmetric crypto > workload > > > using > > > > > > the > > > > > > > > > > same > > > > > > > > > > > > algorithm, key, and direction being processed by CPU > > > > > > > > > > > > cycles > > > > > > >

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-30 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > > > > This action type allows the burst of symmetric crypto > > > > > > > > > > > workload > > using > > > > > the > > > > > > > > > same > > > > > > > > > > > algorithm, key, and direction being processed by CPU > > > > > > > > > > > cycles > > > > > > > synchronously.

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-27 Thread Akhil Goyal
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Wednesday, September 25, 2019 11:54 PM > To: Akhil Goyal ; 'dev@dpdk.org' ; De > Lara Guarch, Pablo ; 'Thomas Monjalon' > > Cc: Zhang, Roy Fan ; Doherty, Declan > ; 'Anoob Joseph' > Subject: RE: [RFC PATCH 1/9] secu

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-25 Thread Ananyev, Konstantin
> > > > > > > > > This action type allows the burst of symmetric crypto > > > > > > > > > workload using > > > the > > > > > > > same > > > > > > > > > algorithm, key, and direction being processed by CPU cycles > > > > > synchronously. > > > > > > > > > This flexible action type does not requir

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-18 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > > > This action type allows the burst of symmetric crypto workload > > > > > > > > using > > the > > > > > > same > > > > > > > > algorithm, key, and direction being processed by CPU cycles > > > > synchronously. > > > > > > > > This flexible action type does not require e

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-16 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > > > > > This action type allows the burst of symmetric crypto workload > > > > > > > using > the > > > > > same > > > > > > > algorithm, key, and direction being processed by CPU cycles > > > synchronously. > > > > > > > This flexible action type does not r

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-16 Thread Ananyev, Konstantin
> Hi Akhil, > > > > > > > > This action type allows the burst of symmetric crypto workload > > > > > > > using the > > > > > same > > > > > > > algorithm, key, and direction being processed by CPU cycles > > > synchronously. > > > > > > > This flexible action type does not require external hard

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-16 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > This action type allows the burst of symmetric crypto workload > > > > > > using the > > > > same > > > > > > algorithm, key, and direction being processed by CPU cycles > > synchronously. > > > > > > This flexible action type does not require external hardware > > > > > >

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-12 Thread Akhil Goyal
Hi Konstantin, > Hi Akhil, > > > > > > > > This action type allows the burst of symmetric crypto workload using > > > > > the > > > same > > > > > algorithm, key, and direction being processed by CPU cycles > synchronously. > > > > > This flexible action type does not require external hardware >

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-11 Thread Ananyev, Konstantin
Hi lads, > > > > You are right, the new API will process the crypto workload, no heavy > > enqueue > > Dequeue operations required. > > > > Cryptodev tends to support multiple crypto devices, including HW and SW. > > The 3-cache line access, iova address computation and assignment, simulation >

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-11 Thread Ananyev, Konstantin
Hi Akhil, > > > > > > This action type allows the burst of symmetric crypto workload using the > > same > > > > algorithm, key, and direction being processed by CPU cycles > > > > synchronously. > > > > This flexible action type does not require external hardware > > > > involvement, > > > > h

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-10 Thread Akhil Goyal
Hi Fan, > > Hi Akhil, > > You are right, the new API will process the crypto workload, no heavy enqueue > Dequeue operations required. > > Cryptodev tends to support multiple crypto devices, including HW and SW. > The 3-cache line access, iova address computation and assignment, simulation > of

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-10 Thread Akhil Goyal
Hi Konstantin, > > Hi Akhil, > > > > This action type allows the burst of symmetric crypto workload using the > same > > > algorithm, key, and direction being processed by CPU cycles synchronously. > > > This flexible action type does not require external hardware involvement, > > > having the

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-06 Thread Ananyev, Konstantin
Hi Akhil, > > This action type allows the burst of symmetric crypto workload using the > > same > > algorithm, key, and direction being processed by CPU cycles synchronously. > > This flexible action type does not require external hardware involvement, > > having the crypto workload processed syn

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-06 Thread Zhang, Roy Fan
Hi Akhil, You are right, the new API will process the crypto workload, no heavy enqueue Dequeue operations required. Cryptodev tends to support multiple crypto devices, including HW and SW. The 3-cache line access, iova address computation and assignment, simulation of async enqueue/dequeue ope

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-06 Thread Akhil Goyal
Hi Fan, > > Hi Akhil, > > This action type allows the burst of symmetric crypto workload using the same > algorithm, key, and direction being processed by CPU cycles synchronously. > This flexible action type does not require external hardware involvement, > having the crypto workload processed

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-04 Thread Zhang, Roy Fan
Hi Akhil, This action type allows the burst of symmetric crypto workload using the same algorithm, key, and direction being processed by CPU cycles synchronously. This flexible action type does not require external hardware involvement, having the crypto workload processed synchronously, and is m

Re: [dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-04 Thread Akhil Goyal
Hi Fan, > > This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action > type to > security library. The type represents performing crypto operation with CPU > cycles. The patch also includes a new API to process crypto operations in > bulk and the function pointers for PMDs. > I am not

[dpdk-dev] [RFC PATCH 1/9] security: introduce CPU Crypto action type and API

2019-09-03 Thread Fan Zhang
This patch introduce new RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO action type to security library. The type represents performing crypto operation with CPU cycles. The patch also includes a new API to process crypto operations in bulk and the function pointers for PMDs. Signed-off-by: Fan Zhang --- l