Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-21 Thread Ferruh Yigit
On 3/21/2018 10:14 AM, Remy Horton wrote: > > On 20/03/2018 15:03, Ferruh Yigit wrote: >> On 3/16/2018 3:36 PM, Remy Horton wrote: > [..] > >>> struct rte_eth_dev_preferred_size { >>> uint16_t burst; >>> uint16_t ring; >>> uint16_t nb_queues; >>> }; >>> struct rte_eth_dev_info { >>>

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-21 Thread Shreyansh Jain
; Z ; Xing, Beilei ; Thomas > Monjalon > Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD- > tuned Tx/Rx parameters > > On 3/21/2018 6:51 AM, Shreyansh Jain wrote: > > On Tue, Mar 20, 2018 at 8:24 PM, Ferruh Yigit > wrote: > >> On 3/16/2018 1:54

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-21 Thread Remy Horton
On 20/03/2018 15:03, Ferruh Yigit wrote: On 3/16/2018 3:36 PM, Remy Horton wrote: [..] struct rte_eth_dev_preferred_size { uint16_t burst; uint16_t ring; uint16_t nb_queues; }; struct rte_eth_dev_info { /* ... */ struct rte_eth_dev_preferred_size prefer

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-21 Thread Ferruh Yigit
On 3/21/2018 6:51 AM, Shreyansh Jain wrote: > On Tue, Mar 20, 2018 at 8:24 PM, Ferruh Yigit wrote: >> On 3/16/2018 1:54 PM, Shreyansh Jain wrote: >>> On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit >>> wrote: > > [...] > Hi Remy, Shreyansh, What do you think about using a variable

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-20 Thread Shreyansh Jain
On Tue, Mar 20, 2018 at 8:24 PM, Ferruh Yigit wrote: > On 3/16/2018 1:54 PM, Shreyansh Jain wrote: >> On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: [...] >>> Hi Remy, Shreyansh, >>> >>> What do you think about using a variable name consistent with existing >>> "default_[rt]xconf" in dev_

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-20 Thread Ferruh Yigit
On 3/16/2018 3:36 PM, Remy Horton wrote: > > On 16/03/2018 13:54, Shreyansh Jain wrote: >> On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: >>> On 3/15/2018 2:39 PM, Bruce Richardson wrote: On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote: > [..] >>> Hi Remy, Shreyansh, >>> >

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-20 Thread Ferruh Yigit
t;>> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit >>>>>>>> Sent: Wednesday, March 14, 2018 5:52 PM >>>>>>>> To: Shreyansh Jain ; Horton, Remy >>>>>>>> ; dev@dpdk.org >>>>>>>> Cc:

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-16 Thread Remy Horton
On 16/03/2018 13:54, Shreyansh Jain wrote: On Thu, Mar 15, 2018 at 8:27 PM, Ferruh Yigit wrote: On 3/15/2018 2:39 PM, Bruce Richardson wrote: On Thu, Mar 15, 2018 at 01:57:13PM +, Ferruh Yigit wrote: [..] Hi Remy, Shreyansh, What do you think about using a variable name consistent with

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-16 Thread Bruce Richardson
v: add support for > >>>>>>> PMD-tuned Tx/Rx parameters > >>>>>>> > >>>>>>> On 3/14/2018 5:23 PM, Shreyansh Jain wrote: > >>>>>>>>> -Original Message- > >>>>>>>>> Fro

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-16 Thread Shreyansh Jain
gt;>>>>> Sent: Wednesday, March 14, 2018 5:52 PM >>>>>>> To: Shreyansh Jain ; Horton, Remy >>>>>>> ; dev@dpdk.org >>>>>>> Cc: Lu, Wenzhuo ; Wu, Jingjing >>>>>>> ; Zhang, Qi Z ; Xing, >>>>

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-15 Thread Ferruh Yigit
To: Shreyansh Jain ; Horton, Remy >>>>>> ; dev@dpdk.org >>>>>> Cc: Lu, Wenzhuo ; Wu, Jingjing >>>>>> ; Zhang, Qi Z ; Xing, Beilei >>>>>> ; Thomas Monjalon >>>>>> Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add sup

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-15 Thread Bruce Richardson
v, Konstantin ; Shreyansh Jain > >> ; Horton, Remy > >> ; dev@dpdk.org > >> Cc: Lu, Wenzhuo ; Wu, Jingjing > >> ; Zhang, Qi Z ; Xing, Beilei > >> ; Thomas Monjalon > >> Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: a

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-15 Thread Bruce Richardson
gt;> On 3/14/2018 5:23 PM, Shreyansh Jain wrote: > >>>>>> -Original Message- > >>>>>> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >>>>>> Sent: Wednesday, March 14, 2018 10:13 PM > >>>>>> To: Remy

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-15 Thread Ferruh Yigit
Wenzhuo ; Wu, Jingjing >> ; Zhang, Qi Z ; Xing, Beilei >> ; Thomas Monjalon >> Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned >> Tx/Rx parameters >> >> On 3/14/2018 6:53 PM, Ananyev, Konstantin wrote: >>> >>> >>&g

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-15 Thread Ferruh Yigit
org] On Behalf Of Ferruh Yigit >>>> Sent: Wednesday, March 14, 2018 5:52 PM >>>> To: Shreyansh Jain ; Horton, Remy >>>> ; dev@dpdk.org >>>> Cc: Lu, Wenzhuo ; Wu, Jingjing >>>> ; Zhang, Qi Z ; Xing, Beilei >>>> ; Thomas Monjalon

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-15 Thread Ananyev, Konstantin
> >> Sent: Wednesday, March 14, 2018 5:52 PM > >> To: Shreyansh Jain ; Horton, Remy > >> ; dev@dpdk.org > >> Cc: Lu, Wenzhuo ; Wu, Jingjing > >> ; Zhang, Qi Z ; Xing, Beilei > >> ; Thomas Monjalon > >> Subject: Re: [dpdk-d

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-15 Thread Remy Horton
On 14/03/2018 15:10, Shreyansh Jain wrote: [..] What do you think renaming structure and variable name, "preferred_dev_config" perhaps? I missed this naming while reading this patch. In the deprecation notice, 'preferred_size' was the name we came up with precisely on this issue of structure h

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Bruce Richardson
h 14, 2018 5:52 PM > >> To: Shreyansh Jain ; Horton, Remy > >> ; dev@dpdk.org > >> Cc: Lu, Wenzhuo ; Wu, Jingjing > >> ; Zhang, Qi Z ; Xing, Beilei > >> ; Thomas Monjalon > >> Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add s

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
Cc: Lu, Wenzhuo ; Wu, Jingjing >> ; Zhang, Qi Z ; Xing, Beilei >> ; Thomas Monjalon >> Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned >> Tx/Rx parameters >> >> On 3/14/2018 5:23 PM, Shreyansh Jain wrote: >>>> --

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ananyev, Konstantin
Monjalon > Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned > Tx/Rx parameters > > On 3/14/2018 5:23 PM, Shreyansh Jain wrote: > >> -Original Message- > >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > >> Sent: Wednesd

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
Xing >> ; Shreyansh Jain ; >> Thomas Monjalon >> Subject: Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD- >> tuned Tx/Rx parameters >> >> On 3/14/2018 3:48 PM, Remy Horton wrote: >>> >>> On 14/03/2018 14:43, Ferruh Yigit wrote: >

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
[dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD- > tuned Tx/Rx parameters > > On 3/14/2018 3:48 PM, Remy Horton wrote: > > > > On 14/03/2018 14:43, Ferruh Yigit wrote: > > [..] > >>> lib/librte_ether/rte_ethdev.c | 18 ++ > >

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/14/2018 3:48 PM, Remy Horton wrote: > > On 14/03/2018 14:43, Ferruh Yigit wrote: > [..] >>> lib/librte_ether/rte_ethdev.c | 18 ++ >>> lib/librte_ether/rte_ethdev.h | 15 +++ >> >> Can you please remove deprecation notice in this patch. > > Done. > >>> + /* Def

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Remy Horton
On 14/03/2018 14:43, Ferruh Yigit wrote: [..] lib/librte_ether/rte_ethdev.c | 18 ++ lib/librte_ether/rte_ethdev.h | 15 +++ Can you please remove deprecation notice in this patch. Done. + /* Defaults for drivers that don't implement preferred +* q

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
[dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD- > tuned Tx/Rx parameters > > On 3/7/2018 12:08 PM, Remy Horton wrote: > > The optimal values of several transmission & reception related > > parameters, such as burst sizes, descriptor ring sizes, and number >

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Ferruh Yigit
On 3/7/2018 12:08 PM, Remy Horton wrote: > The optimal values of several transmission & reception related > parameters, such as burst sizes, descriptor ring sizes, and number > of queues, varies between different network interface devices. This > patch allows individual PMDs to specify preferred pa

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Remy Horton
On 14/03/2018 12:28, Shreyansh Jain wrote: [..] + /* Use default specified by driver, if nb_rc_desc is zero */ ^^^ Should be '_rx_' [..] Other than the above; Ok - v2 on the way :) Acked-by

Re: [dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-14 Thread Shreyansh Jain
> -Original Message- > From: Remy Horton [mailto:remy.hor...@intel.com] > Sent: Wednesday, March 7, 2018 5:39 PM > To: dev@dpdk.org > Cc: Wenzhuo Lu ; Jingjing Wu > ; Qi Zhang ; Beilei Xing > ; Shreyansh Jain ; > Thomas Monjalon > Subject: [RFC PATCH v1 1/4] ethdev: add support for PMD-tun

[dpdk-dev] [RFC PATCH v1 1/4] ethdev: add support for PMD-tuned Tx/Rx parameters

2018-03-07 Thread Remy Horton
The optimal values of several transmission & reception related parameters, such as burst sizes, descriptor ring sizes, and number of queues, varies between different network interface devices. This patch allows individual PMDs to specify preferred parameter values. Signed-off-by: Remy Horton ---