Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-09-01 Thread Mattias Rönnblom
On 2021-08-25 17:31, Honnappa Nagarahalli wrote: On 2021-08-24 23:30, Stephen Hemminger wrote: On Tue, 24 Aug 2021 20:03:03 + Honnappa Nagarahalli wrote: One difference between this implementation and the previous one is this busy loop. rte_pause() relaxes the cpu, but will not make t

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-09-01 Thread Honnappa Nagarahalli
> > > >> > >> On 2021-08-24 23:30, Stephen Hemminger wrote: > >>> On Tue, 24 Aug 2021 20:03:03 + > >>> Honnappa Nagarahalli wrote: > >>> > > One difference between this implementation and the previous one is > > this busy loop. rte_pause() relaxes the cpu, but will not make the >

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-30 Thread Honnappa Nagarahalli
> > On Tue, 24 Aug 2021 20:03:03 + > Honnappa Nagarahalli wrote: > > > > One difference between this implementation and the previous one is > > > this busy loop. rte_pause() relaxes the cpu, but will not make the > > > calling thread to sleep and wait for the sync event. So here we can > >

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-25 Thread Stephen Hemminger
On Wed, 25 Aug 2021 15:23:08 + Honnappa Nagarahalli wrote: > > > > > > On 2021-08-02 07:16, Honnappa Nagarahalli wrote: > > > The current described behaviour of rte_ctrl_thread_create is rigid > > > which makes the implementation of the function complex. > > > The behavior is abstracted

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-25 Thread Honnappa Nagarahalli
> > On 2021-08-24 23:30, Stephen Hemminger wrote: > > On Tue, 24 Aug 2021 20:03:03 + > > Honnappa Nagarahalli wrote: > > > >>> One difference between this implementation and the previous one is > >>> this busy loop. rte_pause() relaxes the cpu, but will not make the > >>> calling thread to

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-25 Thread Honnappa Nagarahalli
> > On 2021-08-02 07:16, Honnappa Nagarahalli wrote: > > The current described behaviour of rte_ctrl_thread_create is rigid > > which makes the implementation of the function complex. > > The behavior is abstracted to allow for simplified implementation. > > > > Have you considered using a POSI

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-25 Thread Mattias Rönnblom
On 2021-08-24 23:30, Stephen Hemminger wrote: On Tue, 24 Aug 2021 20:03:03 + Honnappa Nagarahalli wrote: One difference between this implementation and the previous one is this busy loop. rte_pause() relaxes the cpu, but will not make the calling thread to sleep and wait for the sync event

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-25 Thread Mattias Rönnblom
On 2021-08-02 07:16, Honnappa Nagarahalli wrote: The current described behaviour of rte_ctrl_thread_create is rigid which makes the implementation of the function complex. The behavior is abstracted to allow for simplified implementation. Have you considered using a POSIX condition variable in

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-24 Thread Honnappa Nagarahalli
> > On Tue, 24 Aug 2021 20:03:03 + > Honnappa Nagarahalli wrote: > > > > One difference between this implementation and the previous one is > > > this busy loop. rte_pause() relaxes the cpu, but will not make the > > > calling thread to sleep and wait for the sync event. So here we can > >

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-24 Thread Stephen Hemminger
On Tue, 24 Aug 2021 20:03:03 + Honnappa Nagarahalli wrote: > > One difference between this implementation and the previous one is this busy > > loop. rte_pause() relaxes the cpu, but will not make the calling thread to > > sleep > > and wait for the sync event. So here we can spin a quite lo

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-24 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > On Mon, Aug 02, 2021 at 12:16:52AM -0500, Honnappa Nagarahalli wrote: > > The current described behaviour of rte_ctrl_thread_create is rigid > > which makes the implementation of the function complex. > > The behavior is abstracted to allow for simplified implementation. >

Re: [dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-23 Thread Olivier Matz
Hi Honnappa, On Mon, Aug 02, 2021 at 12:16:52AM -0500, Honnappa Nagarahalli wrote: > The current described behaviour of rte_ctrl_thread_create is > rigid which makes the implementation of the function complex. > The behavior is abstracted to allow for simplified implementation. I agree that the b

[dpdk-dev] [RFC v2] eal: simplify the implementation of rte_ctrl_thread_create

2021-08-01 Thread Honnappa Nagarahalli
The current described behaviour of rte_ctrl_thread_create is rigid which makes the implementation of the function complex. The behavior is abstracted to allow for simplified implementation. Signed-off-by: Honnappa Nagarahalli --- v2: Used compiler's C++11 atomic built-ins to access the shared var