Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-02-03 Thread Eelco Chaudron
On 30 Jan 2020, at 21:20, Thomas Monjalon wrote: Yes, sorry, this is what I meant. Given 19.11.0 already has the symbol as experimental, and that applications like OVS had to accept it as experimental, why removing experimental tag in 19.11.1? I think it was mentioned that it was preferr

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-31 Thread Ferruh Yigit
On 1/30/2020 12:33 PM, Thomas Monjalon wrote: > Hi, > > I disagree with the need of this patch. > The symbol was experimental, meaning we can change it. > Removing experimental tag is not an ABI break. In theory what you said is correct, this is experimental API and anything can happen to it, thi

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Thomas Monjalon
30/01/2020 17:15, Eelco Chaudron: > On 30 Jan 2020, at 17:04, Luca Boccassi wrote: > > On Thu, 2020-01-30 at 16:55 +0100, Thomas Monjalon wrote: > >> 30/01/2020 15:21, Luca Boccassi: > >>> On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote: > 30/01/2020 13:57, Luca Boccassi: > > On T

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Eelco Chaudron
On 30 Jan 2020, at 17:04, Luca Boccassi wrote: On Thu, 2020-01-30 at 16:55 +0100, Thomas Monjalon wrote: 30/01/2020 15:21, Luca Boccassi: On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote: 30/01/2020 13:57, Luca Boccassi: On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: H

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Luca Boccassi
On Thu, 2020-01-30 at 16:55 +0100, Thomas Monjalon wrote: > 30/01/2020 15:21, Luca Boccassi: > > On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote: > > > 30/01/2020 13:57, Luca Boccassi: > > > > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: > > > > > Hi, > > > > > > > > > > I di

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Thomas Monjalon
30/01/2020 15:21, Luca Boccassi: > On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote: > > 30/01/2020 13:57, Luca Boccassi: > > > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: > > > > Hi, > > > > > > > > I disagree with the need of this patch. > > > > The symbol was experimental,

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Luca Boccassi
On Thu, 2020-01-30 at 15:17 +0100, Thomas Monjalon wrote: > 30/01/2020 13:57, Luca Boccassi: > > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: > > > Hi, > > > > > > I disagree with the need of this patch. > > > The symbol was experimental, meaning we can change it. > > > Removing exper

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Thomas Monjalon
30/01/2020 13:57, Luca Boccassi: > On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: > > Hi, > > > > I disagree with the need of this patch. > > The symbol was experimental, meaning we can change it. > > Removing experimental tag is not an ABI break. > > Hi, > > This symbol change was re

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Luca Boccassi
On Thu, 2020-01-30 at 13:33 +0100, Thomas Monjalon wrote: > Hi, > > I disagree with the need of this patch. > The symbol was experimental, meaning we can change it. > Removing experimental tag is not an ABI break. Hi, This symbol change was requested for backport in 19.11.x, and experimental or

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-30 Thread Thomas Monjalon
Hi, I disagree with the need of this patch. The symbol was experimental, meaning we can change it. Removing experimental tag is not an ABI break. 29/01/2020 17:43, Ferruh Yigit: > Duplicated the existing symbol and versioned one as experimental and > other as stable. [..] > --- a/lib/librte_mete

Re: [dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Andrzej Ostruszka
On 1/29/20 5:43 PM, Ferruh Yigit wrote: [...] > diff --git a/lib/librte_meter/rte_meter.c b/lib/librte_meter/rte_meter.c > index da01429a8..5244537fa 100644 > --- a/lib/librte_meter/rte_meter.c > +++ b/lib/librte_meter/rte_meter.c > @@ -9,6 +9,7 @@ > #include > #include > #include > +#include

[dpdk-dev] [RFC v2] meter: fix ABI break due to experimental tag removal

2020-01-29 Thread Ferruh Yigit
Duplicated the existing symbol and versioned one as experimental and other as stable. Created VERSION_SYMBOL_EXPERIMENTAL helper macro. Updated the 'check-experimental-syms.sh' buildtool, which was complaining that the symbol is in EXPERIMENTAL tag in .map file but it is not in the .experimental