Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-10-07 Thread Ferruh Yigit
On 10/7/2019 10:01 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > Hi Ferruh, > >> Hi Jakub, >> >> While testing your zero-copy patch [1], I stuck to a bind() error [2]. >> When provided a socket length bigger than "sizeof(struct sockaddr)", bind() >> fails. I am test

Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-10-07 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
Hi Ferruh, > Hi Jakub, > > While testing your zero-copy patch [1], I stuck to a bind() error [2]. > When provided a socket length bigger than "sizeof(struct sockaddr)", bind() > fails. I am testing this on a Fedora system. > I wonder if there is a check in glibc related to the length. Z

Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-10-04 Thread Yigit, Ferruh
On 7/16/2019 6:20 PM, Stephen Hemminger wrote: > The key size for memif is 256 but the unix domain socket structure has > space for 100 bytes. Change it to use a larger buffer and not hard > code the keysize everywhere. > > Not sure what purpose of socket is anyway since there is no code > which c

Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-09-13 Thread Ferruh Yigit
On 8/30/2019 8:17 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > >> -Original Message- >> From: Stephen Hemminger >> Sent: Tuesday, July 16, 2019 7:21 PM >> To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at >> Cisco) >> Cc: Stephen He

Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-08-30 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, July 16, 2019 7:21 PM > To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at > Cisco) > Cc: Stephen Hemminger > Subject: [RFC v3] net/memif: allow for full key size in socket name > > The key size for

[dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name

2019-07-16 Thread Stephen Hemminger
The key size for memif is 256 but the unix domain socket structure has space for 100 bytes. Change it to use a larger buffer and not hard code the keysize everywhere. Not sure what purpose of socket is anyway since there is no code which connects to it in the current tree anyway? Still an RFC, ha