Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-07-06 Thread Olivier Matz
On Mon, Jul 06, 2020 at 09:36:25AM +0200, Olivier Matz wrote: > Hi Hongzhi, > > I suggest the following title instead: > > net: fix checksum on big endian CPUs > > On Wed, Jun 24, 2020 at 05:11:19PM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas M

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-07-06 Thread Olivier Matz
Hi Hongzhi, I suggest the following title instead: net: fix checksum on big endian CPUs On Wed, Jun 24, 2020 at 05:11:19PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Wednesday, June 24, 2020 5:04 PM > > > > 24/06/2020 15:00,

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-06-24 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Wednesday, June 24, 2020 5:04 PM > > 24/06/2020 15:00, Morten Brørup: > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Wednesday, June 24, 2020 2:22 PM > > > > > > 27/05/2020 15:40, guohongzhi: > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-06-24 Thread Thomas Monjalon
24/06/2020 15:00, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Wednesday, June 24, 2020 2:22 PM > > > > 27/05/2020 15:40, guohongzhi: > > > From: Hongzhi Guo > > > > > > __rte_raw_cksum should consider Big Endian. > > > > We need to explain the logic in the com

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-06-24 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Wednesday, June 24, 2020 2:22 PM > > 27/05/2020 15:40, guohongzhi: > > From: Hongzhi Guo > > > > __rte_raw_cksum should consider Big Endian. > > We need to explain the logic in the commit log. Having grown up with big endian CPUs, rea

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-06-24 Thread Thomas Monjalon
27/05/2020 15:40, guohongzhi: > From: Hongzhi Guo > > __rte_raw_cksum should consider Big Endian. We need to explain the logic in the commit log. > Signed-off-by: Hongzhi Guo > --- > +#if (RTE_BYTE_ORDER == RTE_BIG_ENDIAN) > + sum += *((const uint8_t *)u16_buf) << 8; > +#else >