Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

2019-06-06 Thread Ilya Maximets
On 03.06.2019 19:13, David Marchand wrote: > > > On Mon, Jun 3, 2019 at 5:37 PM Ilya Maximets > wrote: > > On 03.06.2019 11:50, David Marchand wrote: > > > > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

2019-06-03 Thread David Marchand
On Mon, Jun 3, 2019 at 5:37 PM Ilya Maximets wrote: > On 03.06.2019 11:50, David Marchand wrote: > > > > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets > wrote: > > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > > 'hotplug' eq

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

2019-06-03 Thread Ilya Maximets
On 03.06.2019 11:50, David Marchand wrote: > > > On Thu, May 30, 2019 at 3:26 PM Ilya Maximets > wrote: > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > 'hotplug' equivalents must return 0 or negative error code. Bus code > > >

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix positive error codes from probe/remove

2019-06-03 Thread David Marchand
On Thu, May 30, 2019 at 3:26 PM Ilya Maximets wrote: > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' and their > 'hotplug' equivalents must return 0 or negative error code. Bus code > About this first part, existing callers in dpdk are not consistent with the api which might explain