Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

2018-05-15 Thread Matan Azrad
Hi From: Chas Williams > There's possibly an issue here: > >         /* If the device isn't started don't handle interrupts */ >         if (!bonded_eth_dev->data->dev_started) >                 return rc; > >         /* verify that port_id is a valid slave of bonded port */ >         for (i = 0

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

2018-05-14 Thread Chas Williams
There's possibly an issue here: /* If the device isn't started don't handle interrupts */ if (!bonded_eth_dev->data->dev_started) return rc; /* verify that port_id is a valid slave of bonded port */ for (i = 0; i < internals->slave_count; i++) {

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/bonding: fix slave activation simultaneously

2018-05-14 Thread Ferruh Yigit
On 5/14/2018 12:45 PM, Doherty, Declan wrote: > On 24/04/2018 12:29 PM, Matan Azrad wrote: >> The bonding PMD decides to activate\deactivate its slaves according to >> the slaves link statuses. >> Thus, it registers to the LSC events of the slaves ports and >> activates\deactivates them from its LS