Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

2017-05-10 Thread Roger B Melton
-sta...@dpdk.org per Thomas I know this patch has already been applied but to complete the loop, I have applied the patch to 17.05-rc4 and verified within my application that the NULL function pointer issue for ixgbe_vf has been resolved. Regards, Roger On 5/10/17 3:00 AM, Wei Dai wrote: h

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

2017-05-10 Thread Thomas Monjalon
10/05/2017 14:33, Laurent Hardy: > Hi Ferruh, Wei, Roger, > PSB > I also redo test plan provided through > http://dpdk.org/dev/patchwork/patch/20502/ > > Thanks & regards, > Laurent > > On 05/10/2017 02:20 PM, Roger B. Melton wrote: > > > > > > On 5/10/17 5:50 AM, Ferruh Yigit wrote: > >> On 5/1

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

2017-05-10 Thread Laurent Hardy
Hi Ferruh, Wei, Roger, PSB I also redo test plan provided through http://dpdk.org/dev/patchwork/patch/20502/ Thanks & regards, Laurent On 05/10/2017 02:20 PM, Roger B. Melton wrote: On 5/10/17 5:50 AM, Ferruh Yigit wrote: On 5/10/2017 8:00 AM, Wei Dai wrote: hw->mac.ops.get_media-type() o

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

2017-05-10 Thread Roger B. Melton
On 5/10/17 5:50 AM, Ferruh Yigit wrote: On 5/10/2017 8:00 AM, Wei Dai wrote: hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not be called directly. It had better be replaced by calling ixgbe_get_media_type( ) to avoid crash. Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

2017-05-10 Thread Ferruh Yigit
On 5/10/2017 8:00 AM, Wei Dai wrote: > hw->mac.ops.get_media-type() of ixgbe VF is NULL and should not > be called directly. It had better be replaced by calling > ixgbe_get_media_type( ) to avoid crash. > > Fixes: c12d22f65b13 ("net/ixgbe: ensure link status is updated") > Cc: sta...@dpdk.org >

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/ixgbe: fix calling null function of VF

2017-05-10 Thread Ferruh Yigit
On 5/10/2017 10:34 AM, Gregory Etelson wrote: > Hello, > > The patch you proposed fixed a crash I experienced in IXGBE VF. > However, there's still another crash possibility > if the code will proceed with speed == 0 condition to > ixgbe_get_link_capabilities > VF mac.ops.get_link_capabilities is