Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

2019-06-19 Thread David Marchand
On Wed, Jun 19, 2019 at 4:23 PM David Marchand wrote: > > On Wed, Jun 19, 2019 at 4:13 PM Sirvys, Andrius > wrote: > >> That sounds like a good idea. Do you have any examples by chance of >> something like this or any advice how to implement. >> >> The string needs to be generated beforehand so

Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

2019-06-19 Thread David Marchand
On Wed, Jun 19, 2019 at 4:13 PM Sirvys, Andrius wrote: > That sounds like a good idea. Do you have any examples by chance of > something like this or any advice how to implement. > > The string needs to be generated beforehand so where would we be able to > put the code in for that. > For the us

Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

2019-06-19 Thread Sirvys, Andrius
That sounds like a good idea. Do you have any examples by chance of something like this or any advice how to implement. The string needs to be generated beforehand so where would we be able to put the code in for that. From: David Marchand [mailto:david.march...@redhat.com] Sent: Tuesday, June 1

Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip

2019-06-18 Thread David Marchand
On Tue, Jun 18, 2019 at 12:59 PM Andrius Sirvys wrote: > crc_strip was removed from lib/librte_ethdev/rte_ethdev.c as the > NICs carry out this operation themselves. However once removed, > the references to it we're forgotten to be taken out in test-pmd. > > Fixes: 323e7b667f18 ("ethdev: make de