Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report

2018-02-12 Thread Ophir Munk
Will issue v2 with commit message updated > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, February 12, 2018 7:55 PM > To: Ophir Munk > Cc: dev@dpdk.org; Pascal Mazon ; Olga Shern > > Subject: Re: [dpdk-stable] [PATCH v1] net/tap: fix CRC strippin

Re: [dpdk-dev] [dpdk-stable] [PATCH v1] net/tap: fix CRC stripping capability report

2018-02-12 Thread Thomas Monjalon
The title should be "add CRC stripping capability". 12/02/2018 15:43, Ophir Munk: > CRC stripping is executed outside of TAP PMD scope. There is no > prevention that TAP reports on Rx CRC stripping capability. We could mention that the CRC stripping is done in the kernel. > It is especially requ