Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-23 Thread Pei, Andy
Hi, I saw Qiang's patch on patchwork today, [v3] drivers: ifpga_rawdev: fix fd leak in rte_fpga_do_pr So I think it seems OK to ignore my patch. -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, April 23, 2019 4:45 PM To: Pei, Andy Cc: Xu, Rosen ; s

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-23 Thread Thomas Monjalon
When you need to re-send a patch, please apply it with "git am" so the original author is kept. Another nit: the title is full of abbreviation, it is hard to read. The title prefix should be "raw/ifpga", even if checkpatch complains. Please re-send, thanks. 23/04/2019 03:36, Xu, Rosen: > Hi Tho

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-22 Thread Xu, Rosen
Hi Thomas, Qian has some problem with his email. So some patch can't be found in patch work. For it's a urgent bug. After we have aligned with Qian, Andy send this patch. Thanks. > -Original Message- > From: Pei, Andy > Sent: Tuesday, April 23, 2019 9:19 > To: Thomas Monjalon ; Xu, Rose

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-22 Thread Pei, Andy
Hi Thomas, My patch is the same as LI Qiang's patch. I was told that Qiang's patch cannot get onto the patchwork, so I just help him do this. -Original Message- From: Thomas Monjalon [mailto:tho...@monjalon.net] Sent: Tuesday, April 23, 2019 1:52 AM To: Xu, Rosen ; Pei, Andy Cc: sta...

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] raw/ifpga_rawdev: fix fd leak in rte fpga do pr

2019-04-22 Thread Thomas Monjalon
> > In rte_fpga_do_pr() function, if 'stat' returns error, > > rte_fpga_do_pr() returns -EINVAL without closing the 'file_fd' that has been > > opened. > > After this patch, 'file_fd' is closed before rte_fpga_do_pr() returns > > -EINVAL > > when 'stat' returns error > > > > Coverity issue: 27944