Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-10 Thread Ferruh Yigit
Lilijun (Jerry) ; xudingke >> ; sta...@dpdk.org >> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double >> free when writev fails >> >> On Thu, 9 Apr 2020 08:03:23 + >> wangyunjian wrote: >> >>> error = tap_write_mbufs

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread wangyunjian
[dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double > free when writev fails > > On Thu, 9 Apr 2020 08:03:23 + > wangyunjian wrote: > > > error = tap_write_mbufs(txq, num_mbufs, mbuf, > > &num_packets, &num_tx_bytes); if (er

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread Stephen Hemminger
On Thu, 9 Apr 2020 08:03:23 + wangyunjian wrote: > error = tap_write_mbufs(txq, num_mbufs, mbuf, > &num_packets, &num_tx_bytes); > if (error == -1) { > txq->stats.errs++; > /* free tso mbufs */ > for (j = 0; j < ret; j++) > rte_pktmbuf_free(mbuf[j]); >

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread Ferruh Yigit
On 4/9/2020 1:53 PM, wangyunjian wrote: > > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Thursday, April 9, 2020 5:52 PM >> To: wangyunjian ; dev@dpdk.org >> Cc: keith.wi...@intel.com; Lilijun (Jerry) ; >> xudingke >> ; sta...@dpdk.org >> Subject:

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Thursday, April 9, 2020 5:52 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/5] net/tap:

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread Ferruh Yigit
On 4/9/2020 9:03 AM, wangyunjian wrote: > > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Tuesday, April 7, 2020 8:35 PM >> To: wangyunjian ; dev@dpdk.org >> Cc: keith.wi...@intel.com; Lilijun (Jerry) ; >> xudingke >> ; sta...@dpdk.org >> Subject: R

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-09 Thread wangyunjian
> -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, April 7, 2020 8:35 PM > To: wangyunjian ; dev@dpdk.org > Cc: keith.wi...@intel.com; Lilijun (Jerry) ; > xudingke > ; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3 1/5] net/tap:

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/5] net/tap: fix mbuf double free when writev fails

2020-04-07 Thread Ferruh Yigit
On 4/7/2020 5:22 AM, wangyunjian wrote: > From: Yunjian Wang > > When the tap_write_mbufs() function return with break, mbuf was freed > without incrementing num_packets. This may lead applications also free > the mbuf. And the pmd_tx_burst() function should returns the number of > original packe