Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-12 Thread Luca Boccassi
On Wed, 2020-11-11 at 15:09 +, Luca Boccassi wrote: > On Wed, 2020-11-11 at 15:03 +, Luca Boccassi wrote: > > On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote: > > > 29/10/2020 23:55, Dmitry Kozlyuk: > > > > MSBuild XML files have to use CRLF line-endings, otherwise any change > > >

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Dmitry Kozlyuk
On Tue, 03 Nov 2020 10:05:43 +, Luca Boccassi wrote: > The patch looks good to me, as I really need all files to be checked in > with LF only as a hard requirement before I can upload to > Debian/Ubuntu, so: > > Acked-by: Luca Boccassi > > Does the change also stop future check-ins of CRLF f

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Luca Boccassi
On Wed, 2020-11-11 at 15:03 +, Luca Boccassi wrote: > On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote: > > 29/10/2020 23:55, Dmitry Kozlyuk: > > > MSBuild XML files have to use CRLF line-endings, otherwise any change > > > results in the whole file being rewritten with CRLF line-ending

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Luca Boccassi
On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote: > 29/10/2020 23:55, Dmitry Kozlyuk: > > MSBuild XML files have to use CRLF line-endings, otherwise any change > > results in the whole file being rewritten with CRLF line-endings by > > Visual Studio. However, it's inconvenient to have such

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Luca Boccassi
On Tue, 2020-11-03 at 10:05 +, Luca Boccassi wrote: > On Tue, 2020-11-03 at 10:42 +0300, Dmitry Kozlyuk wrote: > > Hi Naty, > > > > > Doesn't the 'input' option gets you original (unmodified) line endings on > > > checkout? > > > If a file in the repo has CRLF endings, Unix devs will get it a

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-11 Thread Thomas Monjalon
29/10/2020 23:55, Dmitry Kozlyuk: > MSBuild XML files have to use CRLF line-endings, otherwise any change > results in the whole file being rewritten with CRLF line-endings by > Visual Studio. However, it's inconvenient to have such files checked-out > with CLRF in Unix environments. > > Add sugge

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-03 Thread Narcisa Ana Maria Vasile
On Fri, Oct 30, 2020 at 01:55:05AM +0300, Dmitry Kozlyuk wrote: > MSBuild XML files have to use CRLF line-endings, otherwise any change > results in the whole file being rewritten with CRLF line-endings by > Visual Studio. However, it's inconvenient to have such files checked-out > with CLRF in Uni

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-03 Thread Luca Boccassi
On Tue, 2020-11-03 at 10:42 +0300, Dmitry Kozlyuk wrote: > Hi Naty, > > > Doesn't the 'input' option gets you original (unmodified) line endings on > > checkout? > > If a file in the repo has CRLF endings, Unix devs will get it as-is (with > > CRLF), right? > > The "input" option is for Unix de

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-02 Thread Dmitry Kozlyuk
Hi Naty, > Doesn't the 'input' option gets you original (unmodified) line endings on > checkout? > If a file in the repo has CRLF endings, Unix devs will get it as-is (with > CRLF), right? The "input" option is for Unix devs only. > Regardless, this is the best option for Unix and since we're

Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-11-02 Thread Narcisa Ana Maria Vasile
On Fri, Oct 30, 2020 at 01:55:05AM +0300, Dmitry Kozlyuk wrote: > MSBuild XML files have to use CRLF line-endings, otherwise any change > results in the whole file being rewritten with CRLF line-endings by > Visual Studio. However, it's inconvenient to have such files checked-out > with CLRF in Uni

[dpdk-dev] [kmods PATCH] windows: normalize line-endings

2020-10-29 Thread Dmitry Kozlyuk
MSBuild XML files have to use CRLF line-endings, otherwise any change results in the whole file being rewritten with CRLF line-endings by Visual Studio. However, it's inconvenient to have such files checked-out with CLRF in Unix environments. Add suggested git configuration to top-level README, so