Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags

2019-08-09 Thread Jerin Jacob Kollanukkaran
erruh.yi...@intel.com; > bruce.richard...@intel.com; Neil Horman ; John > McNamara ; Marko Kovacevic > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev > offload flags > > I think the silent breaking is still not solved for DEV_RX_OFFLOAD_RSS_HASH

Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags

2019-08-09 Thread Andrew Rybchenko
On 8/9/19 12:13 PM, Tom Barbette wrote: I think the silent breaking is still not solved for DEV_RX_OFFLOAD_RSS_HASH and DEV_RX_OFFLOAD_FLOW_MARK. An old application will still compile without any problem, but the RSS hash will not be written and the app will break... They should be negative.

Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags

2019-08-09 Thread Tom Barbette
I think the silent breaking is still not solved for DEV_RX_OFFLOAD_RSS_HASH and DEV_RX_OFFLOAD_FLOW_MARK. An old application will still compile without any problem, but the RSS hash will not be written and the app will break... They should be negative. Eg DEV_RX_OFFLOAD_NO_RSS_HASH and DEV_RX_

Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags

2019-08-09 Thread Pavan Nikhilesh Bhagavatula
Ferruh >; Richardson, Bruce >; Neil Horman >; Mcnamara, John >; Kovacevic, Marko > >Cc: dev@dpdk.org >Subject: RE: [dpdk-dev] [patch v4] doc: announce API change in >ethdev offload flags >Hi > >> >> From: Pavan Nikhilesh >> >> Add new offload

Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags

2019-08-09 Thread Ananyev, Konstantin
Hi > > From: Pavan Nikhilesh > > Add new offload flags ``DEV_RX_OFFLOAD_RSS`` and ``DEV_RX_OFFLOAD_FLOW_MARK``. > Add new function ``rte_eth_dev_set_supported_ptypes`` to allow application to > set specific ptypes to be updated in ``rte_mbuf::packet_type`` > > Signed-off-by: Pavan Nikhilesh

[dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags

2019-08-09 Thread pbhagavatula
From: Pavan Nikhilesh Add new offload flags ``DEV_RX_OFFLOAD_RSS`` and ``DEV_RX_OFFLOAD_FLOW_MARK``. Add new function ``rte_eth_dev_set_supported_ptypes`` to allow application to set specific ptypes to be updated in ``rte_mbuf::packet_type`` Signed-off-by: Pavan Nikhilesh Acked-by: Andrew Rybch