Re: [dpdk-dev] [v2 PATCH] usertools: show an error message if unable to reserve requested hugepages

2021-01-07 Thread Stephen Hemminger
On Thu, 7 Jan 2021 13:06:35 +0500 Sarosh Arif wrote: > On Thu, Dec 17, 2020 at 11:19 PM Stephen Hemminger > wrote: > > > > On Thu, 17 Dec 2020 16:16:16 +0500 > > Sarosh Arif wrote: > > > > > +if get_hugepages(path) != pages: > > > +print("Unable to reserve required pages. The page

Re: [dpdk-dev] [v2 PATCH] usertools: show an error message if unable to reserve requested hugepages

2021-01-07 Thread Sarosh Arif
On Thu, Dec 17, 2020 at 11:19 PM Stephen Hemminger wrote: > > On Thu, 17 Dec 2020 16:16:16 +0500 > Sarosh Arif wrote: > > > +if get_hugepages(path) != pages: > > +print("Unable to reserve required pages. The pages reserved are:") > > +global SHOW_HUGEPAGES > > +SHOW_HU

Re: [dpdk-dev] [v2 PATCH] usertools: show an error message if unable to reserve requested hugepages

2020-12-17 Thread Stephen Hemminger
On Thu, 17 Dec 2020 16:16:16 +0500 Sarosh Arif wrote: > +if get_hugepages(path) != pages: > +print("Unable to reserve required pages. The pages reserved are:") > +global SHOW_HUGEPAGES > +SHOW_HUGEPAGES = True Please don't add global's to this script. The script is

[dpdk-dev] [v2 PATCH] usertools: show an error message if unable to reserve requested hugepages

2020-12-17 Thread Sarosh Arif
Sometimes the system is unable to reserve the requested hugepages because enough space is not available in the RAM. In that case, currently the script displays no error message hence the user can be under the delusion that the hugepages he requested are all successfully reserved. This patch display