Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-06 Thread Maxime Coquelin
On 5/6/20 1:37 PM, David Marchand wrote: > On Wed, May 6, 2020 at 12:51 PM Jerin Jacob wrote: 3) if yes, Please fix RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | vfio-pci"); >>> >>> While support gets removed, what about: >>> >>> RTE_PMD_REGISTER_KMOD_DEP(net_vi

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-06 Thread David Marchand
On Wed, May 6, 2020 at 12:51 PM Jerin Jacob wrote: > > > 3) if yes, Please fix RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio > > > | uio_pci_generic | vfio-pci"); > > > > While support gets removed, what about: > > > > RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | > > vfi

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-06 Thread Jerin Jacob
On Wed, May 6, 2020 at 1:23 PM Maxime Coquelin wrote: > > > > On 5/6/20 8:43 AM, Jerin Jacob wrote: > > On Wed, May 6, 2020 at 12:05 PM Maxime Coquelin > > wrote: > >> > >> Hi, > >> > >> On 5/5/20 6:16 PM, David Marchand wrote: > >>> On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > >> > >

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-06 Thread Maxime Coquelin
On 5/6/20 8:43 AM, Jerin Jacob wrote: > On Wed, May 6, 2020 at 12:05 PM Maxime Coquelin > wrote: >> >> Hi, >> >> On 5/5/20 6:16 PM, David Marchand wrote: >>> On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: >> >> Removing this special case could break x86 applications running with >>>

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread Jerin Jacob
On Wed, May 6, 2020 at 12:05 PM Maxime Coquelin wrote: > > Hi, > > On 5/5/20 6:16 PM, David Marchand wrote: > > On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > > Removing this special case could break x86 applications running with > legacy virtio. > > > On the pl

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread Maxime Coquelin
Hi, On 5/5/20 6:16 PM, David Marchand wrote: > On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: Removing this special case could break x86 applications running with legacy virtio. On the plus side, we have been announcing for some time in virtio: RTE_PMD_REGIST

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread David Marchand
On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > > > > > > Removing this special case could break x86 applications running with > > > legacy virtio. > > > > > > > > > On the plus side, we have been announcing for some time in virtio: > > > RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-05-05 Thread Jerin Jacob
On Tue, Apr 28, 2020 at 3:04 PM Jerin Jacob wrote: > > On Tue, Apr 28, 2020 at 2:21 PM David Marchand > wrote: > > > > On Sun, Apr 26, 2020 at 10:06 PM Thomas Monjalon > > wrote: > > > > > > 26/04/2020 20:41, Jerin Jacob: > > > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > > > wrote:

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-28 Thread Jerin Jacob
On Tue, Apr 28, 2020 at 2:21 PM David Marchand wrote: > > On Sun, Apr 26, 2020 at 10:06 PM Thomas Monjalon wrote: > > > > 26/04/2020 20:41, Jerin Jacob: > > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > > wrote: > > > > > > > > 26/04/2020 19:38, jer...@marvell.com: > > > > > From: Jeri

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-28 Thread David Marchand
On Sun, Apr 26, 2020 at 10:06 PM Thomas Monjalon wrote: > > 26/04/2020 20:41, Jerin Jacob: > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > wrote: > > > > > > 26/04/2020 19:38, jer...@marvell.com: > > > > From: Jerin Jacob > > > > > > > > If the PCI device is not attached to any driver

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-27 Thread Jerin Jacob
On Mon, Apr 27, 2020 at 1:36 AM Thomas Monjalon wrote: > > 26/04/2020 20:41, Jerin Jacob: > > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon > > wrote: > > > > > > 26/04/2020 19:38, jer...@marvell.com: > > > > From: Jerin Jacob > > > > > > > > If the PCI device is not attached to any driver t

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-26 Thread Thomas Monjalon
26/04/2020 20:41, Jerin Jacob: > On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon wrote: > > > > 26/04/2020 19:38, jer...@marvell.com: > > > From: Jerin Jacob > > > > > > If the PCI device is not attached to any driver then there is no > > > point in probing it. As an optimization, skip the PCI d

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-26 Thread Jerin Jacob
On Sun, Apr 26, 2020 at 11:38 PM Thomas Monjalon wrote: > > 26/04/2020 19:38, jer...@marvell.com: > > From: Jerin Jacob > > > > If the PCI device is not attached to any driver then there is no > > point in probing it. As an optimization, skip the PCI device probe if > > the PCI device driver of t

Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-26 Thread Thomas Monjalon
26/04/2020 19:38, jer...@marvell.com: > From: Jerin Jacob > > If the PCI device is not attached to any driver then there is no > point in probing it. As an optimization, skip the PCI device probe if > the PCI device driver of type RTE_KDRV_NONE. > > Signed-off-by: Jerin Jacob > --- > Notes: > -

[dpdk-dev] [PATCH] bus/pci: optimize pci device probe

2020-04-26 Thread jerinj
From: Jerin Jacob If the PCI device is not attached to any driver then there is no point in probing it. As an optimization, skip the PCI device probe if the PCI device driver of type RTE_KDRV_NONE. Signed-off-by: Jerin Jacob --- Notes: -- - virtio drivers does special treatment based on RTE